FAQ
Reviewers: ken2,

Message:
Hello ken2 (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
cmd/gc: fix go:nointerface export comment

Please review this at http://codereview.appspot.com/6815073/

Affected files:
M src/cmd/gc/export.c


Index: src/cmd/gc/export.c
===================================================================
--- a/src/cmd/gc/export.c
+++ b/src/cmd/gc/export.c
@@ -273,13 +273,13 @@
Bprint(bout, "\ttype %#S %#lT\n", t->sym, t);
for(i=0; i<n; i++) {
f = m[i];
+ if(f->nointerface)
+ Bprint(bout, "\t//go:nointerface\n");
if (f->type->nname && f->type->nname->inl) { // nname was set by caninl
// when lazily typechecking inlined bodies, some re-exported ones may
not have been typechecked yet.
// currently that can leave unresolved ONONAMEs in import-dot-ed
packages in the wrong package
if(debug['l'] < 2)
typecheckinl(f->type->nname);
- if(f->nointerface)
- Bprint(bout, "\t//go:nointerface\n");
Bprint(bout, "\tfunc (%#T) %#hhS%#hT { %#H }\n",
getthisx(f->type)->type, f->sym, f->type, f->type->nname->inl);
reexportdeplist(f->type->nname->inl);
} else

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedNov 7, '12 at 2:12p
activeNov 7, '12 at 8:36p
posts3
users2
websitegolang.org

2 users in discussion

Rsc: 2 posts Ken: 1 post

People

Translate

site design / logo © 2022 Grokbase