FAQ
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go


Description:
net: fix protocol number for IPv6 test

The protocol number of ICMP for IPv6 is 58, not 1.

Please review this at http://codereview.appspot.com/6810093/

Affected files:
M src/pkg/net/ipraw_test.go


Index: src/pkg/net/ipraw_test.go
===================================================================
--- a/src/pkg/net/ipraw_test.go
+++ b/src/pkg/net/ipraw_test.go
@@ -21,7 +21,7 @@
ipv6 bool // test with underlying AF_INET6 socket
}{
{"ip4:icmp", "", "127.0.0.1", false},
- {"ip6:icmp", "", "::1", true},
+ {"ip6:ipv6-icmp", "", "::1", true},
}

func TestICMP(t *testing.T) {

Search Discussions

  • Brad Fitzpatrick at Nov 7, 2012 at 12:29 pm
    LGTM
    On Wed, Nov 7, 2012 at 11:15 AM, wrote:

    Reviewers: golang-dev_googlegroups.com,

    Message:
    Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

    I'd like you to review this change to
    https://code.google.com/p/go


    Description:
    net: fix protocol number for IPv6 test

    The protocol number of ICMP for IPv6 is 58, not 1.

    Please review this at http://codereview.appspot.com/**6810093/<http://codereview.appspot.com/6810093/>

    Affected files:
    M src/pkg/net/ipraw_test.go


    Index: src/pkg/net/ipraw_test.go
    ==============================**==============================**=======
    --- a/src/pkg/net/ipraw_test.go
    +++ b/src/pkg/net/ipraw_test.go
    @@ -21,7 +21,7 @@
    ipv6 bool // test with underlying AF_INET6 socket
    }{
    {"ip4:icmp", "", "127.0.0.1", false},
    - {"ip6:icmp", "", "::1", true},
    + {"ip6:ipv6-icmp", "", "::1", true},
    }

    func TestICMP(t *testing.T) {

  • Mikioh Mikioh at Nov 7, 2012 at 12:55 pm
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=e1d0c77a3cd5 ***

    net: fix protocol number for IPv6 test

    The protocol number of ICMP for IPv6 is 58, not 1.

    R=golang-dev, bradfitz
    CC=golang-dev
    http://codereview.appspot.com/6810093


    http://codereview.appspot.com/6810093/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedNov 7, '12 at 10:15a
activeNov 7, '12 at 12:55p
posts3
users2
websitegolang.org

2 users in discussion

Mikioh Mikioh: 2 posts Brad Fitzpatrick: 1 post

People

Translate

site design / logo © 2022 Grokbase