Reviewers: ken2,
Message:
Hello ken2 (cc: golang-dev@googlegroups.com),
I'd like you to review this change to
https://code.google.com/p/go/
Description:
cmd/gc: annotate local variables with unique ids for inlining
Avoids problems with local declarations shadowing other names.
We write a more explicit form than the incoming program, so there
may be additional type annotations. For example:
int := "hello"
j := 2
would normally turn into
var int string = "hello"
var j int = 2
but the int variable shadows the int type in the second line.
This CL marks all local variables with a per-function sequence number,
so that this would instead be:
var int·1 string = "hello"
var j·2 int = 2
Fixes issue 4326.
Please review this at http://codereview.appspot.com/6816100/
Affected files:
M src/cmd/gc/dcl.c
M src/cmd/gc/esc.c
M src/cmd/gc/fmt.c
M src/pkg/exp/types/gcimporter_test.go
A test/fixedbugs/issue4326.dir/p1.go
A test/fixedbugs/issue4326.dir/p2.go
A test/fixedbugs/issue4326.dir/q1.go
A test/fixedbugs/issue4326.dir/q2.go
A test/fixedbugs/issue4326.dir/z.go
A test/fixedbugs/issue4326.go
