FAQ
Reviewers: dfc,

Message:
Hello dave@cheney.net (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.net


Description:
go.net/ipv4: make supportsNewIPInput const

Please review this at http://codereview.appspot.com/6822083/

Affected files:
M ipv4/header.go


Index: ipv4/header.go
===================================================================
--- a/ipv4/header.go
+++ b/ipv4/header.go
@@ -120,7 +120,7 @@

// Please refer to the online manual; IP(4) on Darwin, FreeBSD and
// OpenBSD. IP(7) on Linux.
-var supportsNewIPInput = runtime.GOOS == "linux" || runtime.GOOS
== "openbsd"
+const supportsNewIPInput = runtime.GOOS == "linux" || runtime.GOOS
== "openbsd"

// Marshal returns the binary encoding of the IPv4 header h.
func (h *Header) Marshal() ([]byte, error) {

Search Discussions

  • Dave Cheney at Nov 6, 2012 at 11:36 am
    LGTM. Nice.
    On Tue, Nov 6, 2012 at 10:08 PM, wrote:
    Reviewers: dfc,

    Message:
    Hello dave@cheney.net (cc: golang-dev@googlegroups.com),

    I'd like you to review this change to
    https://code.google.com/p/go.net


    Description:
    go.net/ipv4: make supportsNewIPInput const

    Please review this at http://codereview.appspot.com/6822083/

    Affected files:
    M ipv4/header.go


    Index: ipv4/header.go
    ===================================================================
    --- a/ipv4/header.go
    +++ b/ipv4/header.go
    @@ -120,7 +120,7 @@

    // Please refer to the online manual; IP(4) on Darwin, FreeBSD and
    // OpenBSD. IP(7) on Linux.
    -var supportsNewIPInput = runtime.GOOS == "linux" || runtime.GOOS ==
    "openbsd"
    +const supportsNewIPInput = runtime.GOOS == "linux" || runtime.GOOS ==
    "openbsd"

    // Marshal returns the binary encoding of the IPv4 header h.
    func (h *Header) Marshal() ([]byte, error) {
  • Mikioh Mikioh at Nov 6, 2012 at 1:00 pm

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedNov 6, '12 at 11:08a
activeNov 6, '12 at 1:00p
posts3
users2
websitegolang.org

2 users in discussion

Mikioh Mikioh: 2 posts Dave Cheney: 1 post

People

Translate

site design / logo © 2022 Grokbase