On 2012/10/31 19:54:48, agl1 wrote:
On Wed, Oct 31, 2012 at 3:51 PM,
On Wed, Oct 31, 2012 at 3:51 PM,
That makes the name sound like it's doing the same thing as the
BenchmarkHash1K functions, where those are streaming and this is
computing the checksum every iteration. Maybe rename the existing
BenchmarkHash1K functions, where those are streaming and this is
computing the checksum every iteration. Maybe rename the existing
BenchmarkHashStream1K, or collapse them into BenchmarkHashStream?
The problem is that the other benchmarks are broken. They should alsofinalise the hash.
(And the 8K one should have an explicit length to make sure that it's
testing the right thing.)
Feel free to fix them or just file a bug against me.
Cheers
AGL
I changed them around to address what I was trying to fix and what I
think you wanted fixed.
https://codereview.appspot.com/6814060/
