FAQ
I don't see the K mapping gone. You need to do a "hg upload 6823044" to
push your local changes to Rietveld.

https://codereview.appspot.com/6823044/

Search Discussions

  • Minux at Oct 29, 2012 at 10:53 am
    you need to add newly changed file to this CL, for example:
    hg file 6823044 misc/vim/plugin/godoc.vim misc/vim/ftplugin/go/godoc.vim

    and then redo 'hg mail 6823044'.
  • Andrey Radev at Oct 29, 2012 at 11:10 am
    Hello golang-dev@googlegroups.com, dsymonds@golang.org,
    minux.ma@gmail.com (cc: golang-dev@googlegroups.com),

    Please take another look.


    http://codereview.appspot.com/6823044/
  • Dsymonds at Oct 29, 2012 at 11:13 am
  • Andrey Radev at Oct 29, 2012 at 11:32 am
    Hello golang-dev@googlegroups.com, dsymonds@golang.org,
    minux.ma@gmail.com (cc: golang-dev@googlegroups.com),

    Please take another look.


    http://codereview.appspot.com/6823044/
  • Dsymonds at Oct 29, 2012 at 11:32 am
    please update misc/vim/readme.txt too.

    https://codereview.appspot.com/6823044/
  • Andrey Radev at Oct 29, 2012 at 11:32 am
    Hello golang-dev@googlegroups.com, dsymonds@golang.org,
    minux.ma@gmail.com (cc: golang-dev@googlegroups.com),

    Please take another look.


    http://codereview.appspot.com/6823044/
  • Dsymonds at Oct 29, 2012 at 12:09 pm
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=507eeea1c3da ***

    misc/vim: fix reimport guard and remove K mapping.

    The "did_ftplugin" lines were ineffective and the "K" mapping was too
    invasive, which is why it was removed.

    R=golang-dev, dsymonds, minux.ma
    CC=golang-dev
    http://codereview.appspot.com/6823044

    Committer: David Symonds <dsymonds@golang.org>


    http://codereview.appspot.com/6823044/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 29, '12 at 10:53a
activeOct 29, '12 at 12:09p
posts8
users3
websitegolang.org

3 users in discussion

Dsymonds: 4 posts Andrey Radev: 3 posts Minux: 1 post

People

Translate

site design / logo © 2022 Grokbase