[golang-dev] Re: code review 6736069: runtime, syscall, os: add os.ExecPath() (string, error) (issue 6736069)

The file names are inappropriate now.

For Plan 9, it depends what you want this for. /proc/PID/text is
always a working name for the executable. Otherwise I don't know if
it's possible.

-rob

do you have suggestions for the filenames? i think executable is
a bit too long, and exec might confuse with the exec syscall.
how about the original execpath?
I've thought about /proc/PID/text, in fact it can pass the test, but
i think the main use of this to determine the original binary's path
so that the binary can access its bundled asset files, for example.

i'd also like to test we can indeed find the other files around the
binary, but given the current go test's behavior, this is difficult
to test.

https://codereview.appspot.com/6736069/

PTAL.

Patch Set 24 is the same as Patch Set 23 except
s/progpath/executable/ in filenames.

https://codereview.appspot.com/6736069/

i'm still not convinced by the idea behind this. the idea seems
intrinsically too unportable to be elevated to the standard library. i
expect to be outvoted.




https://codereview.appspot.com/6736069/diff/43014/src/pkg/os/executable.go
File src/pkg/os/executable.go (right):

https://codereview.appspot.com/6736069/diff/43014/src/pkg/os/executable.go#newcode7
src/pkg/os/executable.go:7: // Executable returns the absolute pathname
of the current
"the absolute pathname" sounds definitive but is actually not
well-defined.

https://codereview.appspot.com/6736069/diff/43014/src/pkg/os/executable_darwin.go
File src/pkg/os/executable_darwin.go (right):

https://codereview.appspot.com/6736069/diff/43014/src/pkg/os/executable_darwin.go#newcode7
src/pkg/os/executable_darwin.go:7: var progPath string // set by
../runtime/progpath_darwin.c
you've still got some progpaths around, in different casings.

https://codereview.appspot.com/6736069/

On 2012/10/28 17:47:49, r wrote:
https://codereview.appspot.com/6736069/diff/43014/src/pkg/os/executable.go#newcode7
well-defined.
i agree it is difficult to define its precise behavior.
however, i think the following description is reasonable:
the return value of Executable is an absolute path that matches the path
used
to launch the executable (assuming no one is modifying the intermediate
paths).

https://codereview.appspot.com/6736069/diff/43014/src/pkg/os/executable_darwin.go#newcode7
All fixed.

https://codereview.appspot.com/6736069/

func executable() (string, error) {
f, err := Open("/proc/" + itoa(Getpid()) + "/text")
if err != nil {
return "", err
}
defer f.Close()
return syscall.Fd2path(int(f.Fd()))
}