FAQ
Reviewers: rsc,

Message:
Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
cmd/gc: inlining functions with local variables

- make sure dclcontext == PAUTO only in function bodies
- introduce PDISCARD to discard declarations in bodies of repeated
imports
- skip printing initializing OAS'es in export mode, assuming they only
occur after ODCL's
- remove ODCL and the initializing OAS from inl.c:ishairy
- fix confused use of ->typecheck in typecheckinl: it's about the ->inl,
not about the fn.
- debuging aids: print ntype on ONAMEs too and -Emm instead of -Ell.

Please review this at http://codereview.appspot.com/6800043/

Affected files:
M src/cmd/gc/dcl.c
M src/cmd/gc/fmt.c
M src/cmd/gc/go.h
M src/cmd/gc/go.y
M src/cmd/gc/inl.c
src/cmd/gc/y.tab.c

Search Discussions

  • Rsc at Oct 29, 2012 at 1:07 pm
    LGTM

    in the cl desc s/:/ / in the fixes issue line


    https://codereview.appspot.com/6800043/
  • Lvd at Oct 29, 2012 at 2:02 pm
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=bb4ee132b967 ***

    cmd/gc: inlining functions with local variables

    - make sure dclcontext == PAUTO only in function bodies
    - introduce PDISCARD to discard declarations in bodies of repeated
    imports
    - skip printing initializing OAS'es in export mode, assuming they only
    occur after ODCL's
    - remove ODCL and the initializing OAS from inl.c:ishairy
    - fix confused use of ->typecheck in typecheckinl: it's about the ->inl,
    not about the fn.
    - debuging aids: print ntype on ONAMEs too and -Emm instead of -Ell.

    fixes issue 2812

    R=rsc
    CC=golang-dev
    http://codereview.appspot.com/6800043


    http://codereview.appspot.com/6800043/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 26, '12 at 5:32p
activeOct 29, '12 at 2:02p
posts3
users2
websitegolang.org

2 users in discussion

Lvd: 2 posts Rsc: 1 post

People

Translate

site design / logo © 2022 Grokbase