FAQ
Reviewers: r,

Message:
Hello r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg


Description:
exp/locale/collate/tools/colcmp: add locale to output of regression
failure.

Please review this at http://codereview.appspot.com/6749058/

Affected files:
M src/pkg/exp/locale/collate/tools/colcmp/colcmp.go


Index: src/pkg/exp/locale/collate/tools/colcmp/colcmp.go
===================================================================
--- a/src/pkg/exp/locale/collate/tools/colcmp/colcmp.go
+++ b/src/pkg/exp/locale/collate/tools/colcmp/colcmp.go
@@ -399,7 +399,7 @@
}

const failedKeyCompare = `
-%d: incorrect comparison result for input:
+%s:%d: incorrect comparison result for input:
a: %q (%.4X)
key: %s
b: %q (%.4X)
@@ -412,7 +412,7 @@
`

const failedCompare = `
-%d: incorrect comparison result for input:
+%s:%d: incorrect comparison result for input:
a: %q (%.4X)
b: %q (%.4X)
Compare(a, b) = %d; want %d.
@@ -453,12 +453,12 @@
count++
a := string(ia.UTF8)
b := string(ib.UTF8)
- fmt.Printf(failedKeyCompare, i-1, a, []rune(a), keyStr(ia.key), b,
[]rune(b), keyStr(ib.key), cmp, goldCmp, keyStr(gold.Key(ia)),
keyStr(gold.Key(ib)))
+ fmt.Printf(failedKeyCompare, t.Locale, i-1, a, []rune(a),
keyStr(ia.key), b, []rune(b), keyStr(ib.key), cmp, goldCmp,
keyStr(gold.Key(ia)), keyStr(gold.Key(ib)))
} else if cmp := t.Col.Compare(ia, ib); cmp != goldCmp {
count++
a := string(ia.UTF8)
b := string(ib.UTF8)
- fmt.Printf(failedKeyCompare, i-1, a, []rune(a), b, []rune(b), cmp,
goldCmp)
+ fmt.Printf(failedCompare, t.Locale, i-1, a, []rune(a), b, []rune(b),
cmp, goldCmp)
}
}
if count > 0 {

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 22, '12 at 12:52p
activeOct 24, '12 at 9:28a
posts3
users2
websitegolang.org

2 users in discussion

Mpvl: 2 posts R: 1 post

People

Translate

site design / logo © 2022 Grokbase