FAQ
*** Submitted as
http://code.google.com/p/go/source/detail?r=73745a0498a8 ***

cmd/gc: rebuild builtin.c

Was not in sync with runtime.go, but the diffs
didn't really matter, so nothing broke.

R=ken2
CC=golang-dev
http://codereview.appspot.com/6733057


http://codereview.appspot.com/6733057/

Search Discussions

  • Rsc at Oct 21, 2012 at 11:12 pm
    Reviewers: ken2,

    Message:
    Hello ken2 (cc: golang-dev@googlegroups.com),

    I'd like you to review this change to
    https://code.google.com/p/go/


    Description:
    cmd/gc: rebuild builtin.c

    Was not in sync with runtime.go, but the diffs
    didn't really matter, so nothing broke.

    Please review this at http://codereview.appspot.com/6733057/

    Affected files:
    M src/cmd/gc/builtin.c


    Index: src/cmd/gc/builtin.c
    ===================================================================
    --- a/src/cmd/gc/builtin.c
    +++ b/src/cmd/gc/builtin.c
    @@ -28,8 +28,6 @@
    "func @\"\".appendstr(@\"\".typ *byte, @\"\".x []byte, @\"\".y string) (?
    []byte)\n"
    "func @\"\".cmpstring(? string, ? string) (? int)\n"
    "func @\"\".eqstring(? string, ? string) (? bool)\n"
    - "func @\"\".slicestring(? string, ? int, ? int) (? string)\n"
    - "func @\"\".slicestring1(? string, ? int) (? string)\n"
    "func @\"\".intstring(? int64) (? string)\n"
    "func @\"\".slicebytetostring(? []byte) (? string)\n"
    "func @\"\".slicerunetostring(? []rune) (? string)\n"
    @@ -37,7 +35,7 @@
    "func @\"\".stringtoslicerune(? string) (? []rune)\n"
    "func @\"\".stringiter(? string, ? int) (? int)\n"
    "func @\"\".stringiter2(? string, ? int) (@\"\".retk int, @\"\".retv
    rune)\n"
    - "func @\"\".copy(@\"\".to any, @\"\".fr any, @\"\".wid uint32) (? int)\n"
    + "func @\"\".copy(@\"\".to any, @\"\".fr any, @\"\".wid uintptr) (? int)\n"
    "func @\"\".slicestringcopy(@\"\".to any, @\"\".fr any) (? int)\n"
    "func @\"\".typ2Itab(@\"\".typ *byte, @\"\".typ2 *byte, @\"\".cache
    **byte) (@\"\".ret *byte)\n"
    "func @\"\".convI2E(@\"\".elem any) (@\"\".ret any)\n"
    @@ -79,7 +77,7 @@
    "func @\"\".selectnbsend(@\"\".chanType *byte, @\"\".hchan chan<- any,
    @\"\".elem any) (? bool)\n"
    "func @\"\".selectnbrecv(@\"\".chanType *byte, @\"\".elem *any,
    @\"\".hchan <-chan any) (? bool)\n"
    "func @\"\".selectnbrecv2(@\"\".chanType *byte, @\"\".elem *any,
    @\"\".received *bool, @\"\".hchan <-chan any) (? bool)\n"
    - "func @\"\".newselect(@\"\".size int) (@\"\".sel *byte)\n"
    + "func @\"\".newselect(@\"\".size int32) (@\"\".sel *byte)\n"
    "func @\"\".selectsend(@\"\".sel *byte, @\"\".hchan chan<- any,
    @\"\".elem *any) (@\"\".selected bool)\n"
    "func @\"\".selectrecv(@\"\".sel *byte, @\"\".hchan <-chan any,
    @\"\".elem *any) (@\"\".selected bool)\n"
    "func @\"\".selectrecv2(@\"\".sel *byte, @\"\".hchan <-chan any,
    @\"\".elem *any, @\"\".received *bool) (@\"\".selected bool)\n"

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 21, '12 at 9:21p
activeOct 21, '12 at 11:12p
posts2
users1
websitegolang.org

1 user in discussion

Rsc: 2 posts

People

Translate

site design / logo © 2022 Grokbase