FAQ
Reviewers: rsc,

Message:
Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
cmd/gc: escape analysis to track flow of in to out parameters.

includes step 0: synthesize outparams, from 6600044
includes step 1,2: give outparams loopdepth 0 and verify unchanged
results
generate esc:$mask tags, but still tie to sink if a param has
mask != 0
from 6610054

adds final steps:
- have esccall generate n->escretval, a list of nodes the function
results flow to
- use these in esccall and ORETURN/OAS2FUNC/and f(g())
- only tie parameters to sink if tag is absent, otherwise according to
mask, tie them to escretval

Please review this at http://codereview.appspot.com/6741044/

Affected files:
M src/cmd/gc/closure.c
M src/cmd/gc/dcl.c
M src/cmd/gc/esc.c
M src/cmd/gc/fmt.c
M src/cmd/gc/go.h

Search Discussions

  • Dave Cheney at Oct 21, 2012 at 10:04 am
    Hi Luuk,

    Does this CL address issues like
    https://code.google.com/p/go/issues/detail?id=3702 ?

    Cheers

    Dave
    On Fri, Oct 19, 2012 at 2:57 AM, wrote:
    Reviewers: rsc,

    Message:
    Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

    I'd like you to review this change to
    https://go.googlecode.com/hg/


    Description:
    cmd/gc: escape analysis to track flow of in to out parameters.

    includes step 0: synthesize outparams, from 6600044
    includes step 1,2: give outparams loopdepth 0 and verify unchanged
    results
    generate esc:$mask tags, but still tie to sink if a param has
    mask != 0
    from 6610054

    adds final steps:
    - have esccall generate n->escretval, a list of nodes the function
    results flow to
    - use these in esccall and ORETURN/OAS2FUNC/and f(g())
    - only tie parameters to sink if tag is absent, otherwise according to
    mask, tie them to escretval

    Please review this at http://codereview.appspot.com/6741044/

    Affected files:
    M src/cmd/gc/closure.c
    M src/cmd/gc/dcl.c
    M src/cmd/gc/esc.c
    M src/cmd/gc/fmt.c
    M src/cmd/gc/go.h
  • Rsc at Oct 21, 2012 at 10:09 pm
    looks good but i'd like to read the diffs again once the other 2 CLs are
    submitted. also, please add tests to test/escape*.go.


    https://codereview.appspot.com/6741044/
  • Gobot at Oct 23, 2012 at 6:54 pm
    R=iant (assigned by bradfitz)

    http://codereview.appspot.com/6741044/
  • Gobot at Oct 23, 2012 at 6:54 pm
    R=bradfitz (assigned by bradfitz)

    http://codereview.appspot.com/6741044/
  • Gobot at Oct 23, 2012 at 6:54 pm
  • Brad Fitzpatrick at Oct 23, 2012 at 6:57 pm
    Sorry for the R=spam

    Maybe I'm the only person who navigates web pages with the keyboard.

    The drop-downs should probably blur once modified or something.
    On Tue, Oct 23, 2012 at 11:54 AM, wrote:

    R=rsc (assigned by bradfitz)

    http://codereview.appspot.com/**6741044/<http://codereview.appspot.com/6741044/>
  • Lvd at Oct 24, 2012 at 2:19 pm
    Hello rsc@golang.org, bradfitz@golang.org (cc: dave@cheney.net,
    gobot@golang.org, golang-dev@googlegroups.com, iant@golang.org,
    rsc@golang.org),

    Please take another look.


    http://codereview.appspot.com/6741044/
  • Lvd at Oct 29, 2012 at 12:38 pm
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=7df8438a2c41 ***

    cmd/gc: escape analysis to track flow of in to out parameters.

    includes step 0: synthesize outparams, from 6600044
    includes step 1,2: give outparams loopdepth 0 and verify unchanged
    results
    generate esc:$mask tags, but still tie to sink if a param has
    mask != 0
    from 6610054

    adds final steps:
    - have esccall generate n->escretval, a list of nodes the function
    results flow to
    - use these in esccall and ORETURN/OAS2FUNC/and f(g())
    - only tie parameters to sink if tag is absent, otherwise according to
    mask, tie them to escretval

    R=rsc, bradfitz
    CC=dave, gobot, golang-dev, iant, rsc
    http://codereview.appspot.com/6741044


    http://codereview.appspot.com/6741044/
  • Rsc at Oct 29, 2012 at 12:39 pm

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 18, '12 at 7:52p
activeOct 29, '12 at 12:39p
posts10
users5
websitegolang.org

People

Translate

site design / logo © 2022 Grokbase