FAQ
Reviewers: r,

Message:
Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.talks


Description:
go.talks/present: address missed review comments

Please review this at http://codereview.appspot.com/6727047/

Affected files:
M present/doc.go
M present/parse.go


Index: present/doc.go
===================================================================
--- a/present/doc.go
+++ b/present/doc.go
@@ -165,6 +165,7 @@
The function html includes the contents of the specified file as
unescaped HTML. This is useful for including custom HTML elements
that cannot be created using only the slide format.
+It is your responsibilty to make sure the included HTML is valid and safe.

.html file.html

Index: present/parse.go
===================================================================
--- a/present/parse.go
+++ b/present/parse.go
@@ -31,7 +31,8 @@

// Register binds the named action, which does not being with a period, to
the
// specified parser and template function to be invoked when the name,
with a
-// period, appears in the slide input text.
+// period, appears in the slide input text. The function argument is an
+// optional template function that is available inside templates as name.
func Register(name string, parser func(fileName string, lineNumber int,
inputLine string) (Elem, error), function interface{}) {
if len(name) == 0 || name[0] == ';' {
panic("bad name in Register: " + name)

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 17, '12 at 4:49a
activeOct 17, '12 at 5:03a
posts3
users2
websitegolang.org

2 users in discussion

Adg: 2 posts R: 1 post

People

Translate

site design / logo © 2022 Grokbase