FAQ
It might be better syscall for windows stuff in another CL, perhaps.


https://codereview.appspot.com/6604072/diff/5001/src/pkg/net/fd_unix.go
File src/pkg/net/fd_unix.go (right):

https://codereview.appspot.com/6604072/diff/5001/src/pkg/net/fd_unix.go#newcode674
src/pkg/net/fd_unix.go:674: var skipReadWriteDeadlineTest bool // used
for testing current package
s/skipReadWriteDeadlineTest/canCancelIO/
also pls move this line before init() as same as fd_windows.go.

https://codereview.appspot.com/6604072/diff/5001/src/pkg/net/fd_windows.go
File src/pkg/net/fd_windows.go (right):

https://codereview.appspot.com/6604072/diff/5001/src/pkg/net/fd_windows.go#newcode21
src/pkg/net/fd_windows.go:21: var skipReadWriteDeadlineTest bool // used
for testing current package
we can drop this variable.

https://codereview.appspot.com/6604072/diff/5001/src/pkg/net/fd_windows.go#newcode139
src/pkg/net/fd_windows.go:139: // Is used on Windows with no CancelIoEx
api only.
It's?

https://codereview.appspot.com/6604072/diff/5001/src/pkg/net/timeout_test.go
File src/pkg/net/timeout_test.go (right):

https://codereview.appspot.com/6604072/diff/5001/src/pkg/net/timeout_test.go#newcode124
src/pkg/net/timeout_test.go:124: if skipReadWriteDeadlineTest {
if !canCancelIO {

https://codereview.appspot.com/6604072/

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 13, '12 at 5:13p
activeOct 13, '12 at 5:13p
posts1
users1
websitegolang.org

1 user in discussion

Mikioh Mikioh: 1 post

People

Translate

site design / logo © 2022 Grokbase