FAQ
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
remy@archlinux.org),

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
cmd/gc: don't squash complex literals when inlining.

Since this patch changes the way complex literals are written
in export data, there are a few other glitches.

Fixes issue 4159.

Please review this at http://codereview.appspot.com/6674047/

Affected files:
M src/cmd/gc/fmt.c
M src/cmd/gc/go.y
M src/cmd/gc/y.tab.c
M src/cmd/gc/y.tab.h
M src/pkg/exp/types/gcimporter.go
M src/pkg/exp/types/staging/gcimporter.go
A test/fixedbugs/bug466.dir/a.go
A test/fixedbugs/bug466.dir/b.go
A test/fixedbugs/bug466.go

Search Discussions

  • Remyoudompheng at Oct 13, 2012 at 11:22 am
    Alternatively we could keep the format and fix the parser when reading
    exported inlinable code, but I'm not sure it is a good idea. Writing
    (a+b) to mean a+bi is weird.

    http://codereview.appspot.com/6674047/
  • Rsc at Oct 16, 2012 at 5:53 pm
  • Remyoudompheng at Oct 17, 2012 at 8:18 pm
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=11f0ba3b7006 ***

    cmd/gc: don't squash complex literals when inlining.

    Since this patch changes the way complex literals are written
    in export data, there are a few other glitches.

    Fixes issue 4159.

    R=golang-dev, rsc
    CC=golang-dev, remy
    http://codereview.appspot.com/6674047


    http://codereview.appspot.com/6674047/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 13, '12 at 11:22a
activeOct 17, '12 at 8:18p
posts4
users2
websitegolang.org

2 users in discussion

Remyoudompheng: 3 posts Rsc: 1 post

People

Translate

site design / logo © 2022 Grokbase