Grokbase › Groups › Go › golang-dev › October 2012
FAQ

On 2012/10/13 17:45:02, iant wrote:
This change does more than simply remove the arguments, and it will
fail to run
on many systems--e.g., those that don't have an interface "en0" or
911, which
includes the typical GNU/Linux system. It's not clear to me that this is an
improvement.
This worked fine on my linux/arm system (closest to hand). I believe
this works because the example includes no // Output: lines. This is
consistent with the tests that precede it in the file that also use the
same setup preamble.

https://codereview.appspot.com/6591076/

Search Discussions

  • Dave Cheney at Oct 14, 2012 at 12:02 am ⇧
    I would LGTM this, but looking at the examples in godoc, none of them
    are accessible. I'm not sure if this is a problem with the examples,
    or godoc.
    On Sun, Oct 14, 2012 at 10:52 AM, wrote:
    On 2012/10/13 17:45:02, iant wrote:

    This change does more than simply remove the arguments, and it will
    fail to run
    on many systems--e.g., those that don't have an interface "en0" or
    911, which
    includes the typical GNU/Linux system. It's not clear to me that this is an
    improvement.

    This worked fine on my linux/arm system (closest to hand). I believe
    this works because the example includes no // Output: lines. This is
    consistent with the tests that precede it in the file that also use the
    same setup preamble.

    https://codereview.appspot.com/6591076/
  • Minux Ma at Oct 14, 2012 at 8:52 am ⇧
    +adg.
    On 2012/10/13 23:55:23, dfc wrote:
    [...] but looking at the examples in godoc, none of them
    are accessible. I'm not sure if this is a problem with the examples,
    or godoc.
    They aren't shown because their names don't follow the normal
    example naming convention (see `godoc testing`). And godoc only
    shows ExampleF(), ExampleT(), and ExampleT_M()-type examples.

    However, i think these free form examples are necessary and
    useful (some types/functions is meant to work together, and it's
    just unreasonable to provide separate examples for them).

    I propose we add a separate standalone examples (or complex
    examples) section to lib/godoc/godoc.html for those examples
    that are not bonded to one specific function/type/method.

    https://codereview.appspot.com/6591076/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 13, '12 at 11:52p
activeOct 14, '12 at 8:52a
posts3
users2
websitegolang.org

2 users in discussion

Dave Cheney: 2 posts Minux Ma: 1 post

Content

People

Support

Translate

site design / logo © 2022 Grokbase