FAQ
Thanks, but there are some things I don't like about this change:

a) adds another js file to load; please put the translation map in
tour.js
b) the keys for the lang map should not be the english sentences, but
rather short keywords that describe the various strings. then there
should be a default english mapping.


https://codereview.appspot.com/6639062/

Search Discussions

  • Jeff Allen at Oct 11, 2012 at 6:43 am
    Translations should not be mixed with code. But a good compromise would
    be to put it in index.html. Your other suggestion loses the default to
    english whichis too bad.

    https://codereview.appspot.com/6639062/
  • Adg at Oct 11, 2012 at 6:58 am

    On 2012/10/11 06:43:38, jeff.allen wrote:
    Translations should not be mixed with code. But a good compromise
    would be to
    put it in index.html. Your other suggestion loses the default to
    english whichis
    too bad.
    I'm not even clear how the translations will be swapped in, so it makes
    no difference whether it's in lang.js or tour.js right now.

    https://codereview.appspot.com/6639062/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 11, '12 at 12:09a
activeOct 11, '12 at 6:58a
posts3
users2
websitegolang.org

2 users in discussion

Adg: 2 posts Jeff Allen: 1 post

People

Translate

site design / logo © 2022 Grokbase