FAQ
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/


Description:
runtime/debug: fix the test
If source are not available, then the stack looks like:
stack_test.go:40:

/tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:15
(0x43fb11)
stack_test.go:40:

/tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:18
(0x43fb7a)
stack_test.go:40:

/tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:37
(0x43fbf4)
stack_test.go:40:

/tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/testing/bla-bla-bla/src/pkg/testing/testing.go:301
(0x43b5ba)
stack_test.go:40:

/tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/bla-bla-bla/src/pkg/runtime/proc.c:276
(0x410670)
stack_test.go:40:
which is 6 lines.

Please review this at http://codereview.appspot.com/6637060/

Affected files:
M src/pkg/runtime/debug/stack_test.go


Index: src/pkg/runtime/debug/stack_test.go
===================================================================
--- a/src/pkg/runtime/debug/stack_test.go
+++ b/src/pkg/runtime/debug/stack_test.go
@@ -36,7 +36,7 @@
func TestStack(t *testing.T) {
b := T(0).method()
lines := strings.Split(string(b), "\n")
- if len(lines) <= 6 {
+ if len(lines) < 6 {
t.Fatal("too few lines")
}
n := 0

Search Discussions

  • Dvyukov at Oct 10, 2012 at 4:48 pm

    On 2012/10/10 16:34:49, minux wrote:
    the change LGTM.
    PS: I wonder why this occurs (can't find source code)
    in run.bash, we need to unset GOROOT_FINAL for it, but I don't
    understand
    why this happens on the -race builder.
    It reproduces when I build as
    $ GOROOT_FINAL=bla-bla-bla ./make.bash

    https://codereview.appspot.com/6637060/
  • Dvyukov at Oct 10, 2012 at 4:49 pm
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=236ee151d1bc ***

    runtime/debug: fix the test
    If source are not available, then the stack looks like:
    stack_test.go:40:

    /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:15
    (0x43fb11)
    stack_test.go:40:

    /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:18
    (0x43fb7a)
    stack_test.go:40:

    /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/debug/bla-bla-bla/src/pkg/runtime/debug/stack_test.go:37
    (0x43fbf4)
    stack_test.go:40:

    /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/testing/bla-bla-bla/src/pkg/testing/testing.go:301
    (0x43b5ba)
    stack_test.go:40:

    /tmp/gobuilder/linux-amd64-race-72b15c5d6f65/go/src/pkg/runtime/bla-bla-bla/src/pkg/runtime/proc.c:276
    (0x410670)
    stack_test.go:40:
    which is 6 lines.

    R=golang-dev, minux.ma
    CC=golang-dev
    http://codereview.appspot.com/6637060


    http://codereview.appspot.com/6637060/
  • Minux Ma at Oct 10, 2012 at 5:32 pm
    the change LGTM.

    PS: I wonder why this occurs (can't find source code)
    in run.bash, we need to unset GOROOT_FINAL for it, but I don't
    understand
    why this happens on the -race builder.

    https://codereview.appspot.com/6637060/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 10, '12 at 3:49p
activeOct 10, '12 at 5:32p
posts4
users2
websitegolang.org

2 users in discussion

Dvyukov: 3 posts Minux Ma: 1 post

People

Translate

site design / logo © 2022 Grokbase