FAQ
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
remy@archlinux.org),

Please take another look.


http://codereview.appspot.com/6640056/

Search Discussions

  • Remyoudompheng at Oct 10, 2012 at 11:43 pm
    Reviewers: golang-dev_googlegroups.com,

    Message:
    Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
    remy@archlinux.org),

    I'd like you to review this change to
    https://go.googlecode.com/hg/


    Description:
    cmd/gc: fix inlining bug for composite literals in if statements.

    Fixes issue 4230.

    Please review this at http://codereview.appspot.com/6640056/

    Affected files:
    M src/cmd/gc/fmt.c
    A test/fixedbugs/bug465.dir/a.go
    A test/fixedbugs/bug465.dir/b.go
    A test/fixedbugs/bug465.go
  • Remyoudompheng at Oct 17, 2012 at 6:49 pm
  • Remyoudompheng at Oct 20, 2012 at 7:40 pm
  • Russ Cox at Oct 21, 2012 at 4:31 pm
    Instead of introducing a new flag, how about just using ( ) around the
    if condition always?
  • Remyoudompheng at Oct 21, 2012 at 6:22 pm
    Just tried doing that and it doesnt work due to the simple statements in
    if/for/switch, they cannot be parenthesized in a simple way
    [as "(i := 1)" is illegal]

    Another option is to systematically parenthesize all composite literals.

    What do you think?

    http://codereview.appspot.com/6640056/
  • Russ Cox at Oct 21, 2012 at 8:13 pm
    Another option is to systematically parenthesize all composite literals.
    sure
  • Remyoudompheng at Oct 22, 2012 at 12:17 am
    Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
    golang-dev@googlegroups.com, remy@archlinux.org),

    Please take another look.


    http://codereview.appspot.com/6640056/
  • Rsc at Oct 22, 2012 at 12:43 am
  • Remyoudompheng at Oct 22, 2012 at 6:38 am
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=7639aa719ae8 ***

    cmd/gc: fix inlining bug for composite literals in if statements.

    Fixes issue 4230.

    R=golang-dev, rsc
    CC=golang-dev, remy
    http://codereview.appspot.com/6640056


    http://codereview.appspot.com/6640056/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 10, '12 at 11:25p
activeOct 22, '12 at 6:38a
posts10
users2
websitegolang.org

2 users in discussion

Remyoudompheng: 7 posts Rsc: 3 posts

People

Translate

site design / logo © 2022 Grokbase