FAQ

Search Discussions

  • Dsymonds at Oct 8, 2012 at 10:17 am
    Reviewers: golang-dev_googlegroups.com,

    Message:
    Hello golang-dev@googlegroups.com,

    I'd like you to review this change to
    https://code.google.com/p/go


    Description:
    doc: update text about hgrc and environment variables.

    Mercurial has supported environment variables in hgrc files since
    version 1.4 (released November 2009).

    Please review this at http://codereview.appspot.com/6619067/

    Affected files:
    M doc/contribute.html


    Index: doc/contribute.html
    ===================================================================
    --- a/doc/contribute.html
    +++ b/doc/contribute.html
    @@ -110,14 +110,13 @@

    <pre>
    [extensions]
    -codereview = YOUR_GO_ROOT/lib/codereview/codereview.py
    +codereview = $GOROOT/lib/codereview/codereview.py

    [ui]
    username = Your Name &lt;you@server.dom&gt;
    </pre>

    -<p>Replace YOUR_GO_ROOT with the value of <code>$GOROOT</code>.
    -The Mercurial configuration file format does not allow environment
    variable substitution.
    +<p>
    The <code>username</code> information will not be used unless
    you are a committer (see below), but Mercurial complains if it is missing.
    </p>
  • David Symonds at Oct 8, 2012 at 10:17 am
  • Minux Ma at Oct 8, 2012 at 10:18 am
    https://codereview.appspot.com/6619067/diff/4001/doc/contribute.html
    File doc/contribute.html (right):

    https://codereview.appspot.com/6619067/diff/4001/doc/contribute.html#newcode113
    doc/contribute.html:113: codereview =
    $GOROOT/lib/codereview/codereview.py
    one possible problem:
    we don't advertise people to set GOROOT these days...
    (in fact, we embed GOROOT in cmd/go so that people don't
    need to bother it)

    Is there any better ways to find the plugin?

    https://codereview.appspot.com/6619067/
  • Dsymonds at Oct 8, 2012 at 10:33 am
    https://codereview.appspot.com/6619067/diff/4001/doc/contribute.html
    File doc/contribute.html (right):

    https://codereview.appspot.com/6619067/diff/4001/doc/contribute.html#newcode113
    doc/contribute.html:113: codereview =
    $GOROOT/lib/codereview/codereview.py
    On 2012/10/08 10:18:19, minux wrote:
    one possible problem:
    we don't advertise people to set GOROOT these days...
    (in fact, we embed GOROOT in cmd/go so that people don't
    need to bother it)
    Is there any better ways to find the plugin?
    The rest of this doc is already assuming $GOROOT is set. It's aimed at
    contributors with a clone of the Hg tree. I think it's reasonable to
    assume they can set $GOROOT, or at least swap it out here if they really
    don't want to set one.

    https://codereview.appspot.com/6619067/
  • Minux Ma at Oct 8, 2012 at 10:44 am

    On 2012/10/08 10:33:30, dsymonds wrote:
    The rest of this doc is already assuming $GOROOT is set. It's aimed at
    contributors with a clone of the Hg tree. I think it's reasonable to
    assume they
    can set $GOROOT, or at least swap it out here if they really don't
    want to set
    one.
    Fair enough. (I don't set $GOROOT, but run.bash assumes it is set, so i
    think it's
    indeed mandatory)
    LGTM.

    https://codereview.appspot.com/6619067/
  • Dsymonds at Oct 8, 2012 at 11:30 am
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=4261c157f226 ***

    doc: update text about hgrc and environment variables.

    Mercurial has supported environment variables in hgrc files since
    version 1.4 (released November 2009).

    R=golang-dev, dave, minux.ma
    CC=golang-dev
    http://codereview.appspot.com/6619067


    http://codereview.appspot.com/6619067/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 8, '12 at 10:14a
activeOct 8, '12 at 11:30a
posts7
users3
websitegolang.org

3 users in discussion

Dsymonds: 4 posts Minux Ma: 2 posts Dave: 1 post

People

Translate

site design / logo © 2022 Grokbase