FAQ
https://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/check.go
File src/pkg/exp/types/staging/check.go (right):

https://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/check.go#newcode286
src/pkg/exp/types/staging/check.go:286: // TODO(gri) why is _ special
here?
On 2012/10/06 22:49:46, rsc wrote:
I can imagine it might be special in that you still want to type-check the
declaration. That is:
var _ int = "hello"
should not be thrown away before being type-checked. But that's also true of
case TypeSpec.
Correct. There's a failure here that I haven't tracked down yet.

https://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/types.go
File src/pkg/exp/types/staging/types.go (right):

https://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/types.go#newcode24
src/pkg/exp/types/staging/types.go:24: // is found. A nil record is not
invoked.
On 2012/10/06 22:49:46, rsc wrote:
On 2012/10/06 22:25:59, r wrote:
what does "A nil record is not invoked" mean?
s//If record is nil, it is not invoked./
And maybe chage record to f or save or something more obviously a
function or
verb.

Done.

https://codereview.appspot.com/6612049/

Search Discussions

  • Gri at Oct 8, 2012 at 1:02 am
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=ad44ea247aa4 ***

    exp/types/staging: more flexible API, cleanups

    - Changed Check signature to take function parameters for
    more flexibility: Now a client can interrupt type checking
    early (via panic in one the upcalls) once the desired
    type information or number of errors is reached. Default
    use is still simple.

    - Cleaned up main typechecking loops. Now does not neglect
    _ declarations anymore.

    - Various other cleanups.

    R=golang-dev, r, rsc
    CC=golang-dev
    http://codereview.appspot.com/6612049


    http://codereview.appspot.com/6612049/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 7, '12 at 11:48p
activeOct 8, '12 at 1:02a
posts2
users1
websitegolang.org

1 user in discussion

Gri: 2 posts

People

Translate

site design / logo © 2021 Grokbase