FAQ
Thank you for your comments. I'm attempting a version of the harness
that uses sshd -i now.


http://codereview.appspot.com/6601043/diff/10001/ssh/sshtest/auth_test.go
File ssh/sshtest/auth_test.go (right):

http://codereview.appspot.com/6601043/diff/10001/ssh/sshtest/auth_test.go#newcode86
ssh/sshtest/auth_test.go:86: func (k *keychain) loadPEM(file string)
error {
On 2012/10/03 20:14:22, agl1 wrote:
It's not obvious where this is used, but I might have missed it.
I've merged this file back into sshtest_test.go, it wasn't carrying its
weight.

http://codereview.appspot.com/6601043/diff/10001/ssh/sshtest/session_test.go
File ssh/sshtest/session_test.go (right):

http://codereview.appspot.com/6601043/diff/10001/ssh/sshtest/session_test.go#newcode19
ssh/sshtest/session_test.go:19: cleanup := startSshd(t)
On 2012/10/03 20:14:22, agl1 wrote:
s/Sshd/SSHd/ perhaps. ("Sshd" looks really weird to me.)
Done.

http://codereview.appspot.com/6601043/diff/10001/ssh/sshtest/sshtest_test.go
File ssh/sshtest/sshtest_test.go (right):

http://codereview.appspot.com/6601043/diff/10001/ssh/sshtest/sshtest_test.go#newcode142
ssh/sshtest/sshtest_test.go:142: <-time.After(100 * time.Millisecond)
On 2012/10/03 20:14:22, agl1 wrote:
This seems unfortunate. Can we have the sshd log to stderr, or a file,
and have a goroutine watch for a log line that indicates that it has
opened the socket? Or perhaps pass -i to sshd and mimic inetd mode?

logging to stdout is easy, cmd = os.Stdout, but rather noisy.

I've never tried fd passing in Go, but it would be the best way, i'll
try to make that work with sshd -i

http://codereview.appspot.com/6601043/

Search Discussions

  • Dave at Oct 4, 2012 at 6:06 am
    Hello agl@golang.org, gustav.paul@gmail.com, kardianos@gmail.com,
    fullung@gmail.com (cc: golang-dev@googlegroups.com),

    Please take another look.


    http://codereview.appspot.com/6601043/
  • Kardianos at Oct 4, 2012 at 6:28 am
    On windows only build tcpip_test.go and not the other tests. Otherwise
    looks fine as far as I can tell.

    https://codereview.appspot.com/6601043/
  • Dave Cheney at Oct 4, 2012 at 6:30 am
    None of these will work on windows (no sshd). Maybe I should use //
    +build tags ?
    On Thu, Oct 4, 2012 at 4:28 PM, wrote:
    On windows only build tcpip_test.go and not the other tests. Otherwise
    looks fine as far as I can tell.

    https://codereview.appspot.com/6601043/
  • Dave at Oct 4, 2012 at 7:47 am
    PTAL. I have reworked the file layout to run these tests on unix
    platforms only. Refactoring to support windows server processes should
    be straight forward.

    http://codereview.appspot.com/6601043/
  • Kardianos at Oct 4, 2012 at 3:12 pm

    On 2012/10/04 07:47:18, dfc wrote:
    PTAL. I have reworked the file layout to run these tests on unix
    platforms only.
    Refactoring to support windows server processes should be straight
    forward.

    LGTM.

    https://codereview.appspot.com/6601043/
  • Agl at Oct 4, 2012 at 4:19 pm
    LGTM.

    Is go.crypto/ssh/sshtest a stutter? Should it be go.crypto/ssh/test? Up
    to you.

    https://codereview.appspot.com/6601043/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 4, '12 at 4:56a
activeOct 4, '12 at 4:19p
posts7
users3
websitegolang.org

3 users in discussion

Dave: 4 posts Kardianos: 2 posts Agl: 1 post

People

Translate

site design / logo © 2021 Grokbase