FAQ
Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
cmd/[568]g: header cleanup.

Please review this at http://codereview.appspot.com/6573059/

Affected files:
M src/cmd/5g/gg.h
M src/cmd/6g/gg.h
M src/cmd/8g/gg.h


Index: src/cmd/5g/gg.h
===================================================================
--- a/src/cmd/5g/gg.h
+++ b/src/cmd/5g/gg.h
@@ -117,14 +117,11 @@
void proglist(void);
Prog* gbranch(int, Type*, int);
Prog* prog(int);
-void gaddoffset(Node*);
void gconv(int, int);
int conv2pt(Type*);
vlong convvtox(vlong, int);
void fnparam(Type*, int, int);
Prog* gop(int, Node*, Node*, Node*);
-void setconst(Addr*, vlong);
-void setaddr(Addr*, Node*);
int optoas(int, Type*);
void ginit(void);
void gclean(void);
Index: src/cmd/6g/gg.h
===================================================================
--- a/src/cmd/6g/gg.h
+++ b/src/cmd/6g/gg.h
@@ -58,7 +58,7 @@
extern vlong unmappedzero;

/*
- * gen.c
+ * ggen.c
*/
void compile(Node*);
void proglist(void);
@@ -81,7 +81,7 @@
int gen_as_init(Node*);

/*
- * cgen
+ * cgen.c
*/
void agen(Node*, Node*);
void igen(Node*, Node*, Node*);
@@ -103,7 +103,6 @@
void proglist(void);
Prog* gbranch(int, Type*, int);
Prog* prog(int);
-void gaddoffset(Node*);
void gconv(int, int);
int conv2pt(Type*);
vlong convvtox(vlong, int);
@@ -125,7 +124,6 @@
void sudoclean(void);
int sudoaddable(int, Node*, Addr*);
void afunclit(Addr*);
-void datagostring(Strlit*, Addr*);
void nodfconst(Node*, Type*, Mpflt*);

/*
@@ -139,6 +137,7 @@
* gobj.c
*/
void datastring(char*, int, Addr*);
+void datagostring(Strlit*, Addr*);

/*
* list.c
Index: src/cmd/8g/gg.h
===================================================================
--- a/src/cmd/8g/gg.h
+++ b/src/cmd/8g/gg.h
@@ -122,14 +122,11 @@
void proglist(void);
Prog* gbranch(int, Type*, int);
Prog* prog(int);
-void gaddoffset(Node*);
void gconv(int, int);
int conv2pt(Type*);
vlong convvtox(vlong, int);
void fnparam(Type*, int, int);
Prog* gop(int, Node*, Node*, Node*);
-void setconst(Addr*, vlong);
-void setaddr(Addr*, Node*);
int optoas(int, Type*);
int foptoas(int, Type*, int);
void ginit(void);
@@ -141,8 +138,6 @@
void nodindreg(Node*, Type*, int);
void nodconst(Node*, Type*, int64);
void gconreg(int, vlong, int);
-void datagostring(Strlit*, Addr*);
-void datastring(char*, int, Addr*);
void buildtxt(void);
Plist* newplist(void);
int isfat(Type*);
@@ -162,6 +157,12 @@
void complexgen(Node*, Node*);

/*
+ * gobj.c
+ */
+void datastring(char*, int, Addr*);
+void datagostring(Strlit*, Addr*);
+
+/*
* list.c
*/
int Aconv(Fmt*);

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 27, '12 at 6:25a
activeSep 27, '12 at 6:34a
posts3
users2
websitegolang.org

2 users in discussion

Remyoudompheng: 2 posts R: 1 post

People

Translate

site design / logo © 2022 Grokbase