FAQ
LGTM.

Please change the changelist description: s/Issue/issue/ in "Update
Issue 4028".

It'd also be nice if the description gave the benchmark numbers.


https://codereview.appspot.com/6548047/diff/11002/src/pkg/bufio/bufio_test.go
File src/pkg/bufio/bufio_test.go (right):

https://codereview.appspot.com/6548047/diff/11002/src/pkg/bufio/bufio_test.go#newcode768
src/pkg/bufio/bufio_test.go:768: for i, _ := range input {
for i := range input {

https://codereview.appspot.com/6548047/diff/11002/src/pkg/bufio/bufio_test.go#newcode814
src/pkg/bufio/bufio_test.go:814: // An onlyReader only implements
io.Reader, no matter what other methods the underlying implementation
may have
Add a full stop to complete the sentence.

Similarly below.

https://codereview.appspot.com/6548047/

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 27, '12 at 1:37a
activeSep 27, '12 at 6:31a
posts5
users2
websitegolang.org

2 users in discussion

Nigeltao: 4 posts Mchaten: 1 post

People

Translate

site design / logo © 2022 Grokbase