FAQ
Reviewers: rsc, rminnich, npe1,

Message:
Hello rsc@golang.org, rminnich@gmail.com, npe@plan9.bell-labs.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
pkg/syscall: Plan 9, 64-bit: Update error checks from sys calls.

The system calls return 32-bit integers. With the recent change
in size of `int' in Go for amd64, the type conversion was not
catching `-1' return values. This change makes the conversion
explicitly `int32'.

Please review this at http://codereview.appspot.com/6576057/

Affected files:
M src/pkg/syscall/mksyscall.pl
M src/pkg/syscall/zsyscall_plan9_amd64.go

Search Discussions

  • R at Sep 27, 2012 at 11:57 pm
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=aa2f44cc25c0 ***

    pkg/syscall: Plan 9, 64-bit: Update error checks from sys calls.

    The system calls return 32-bit integers. With the recent change
    in size of `int' in Go for amd64, the type conversion was not
    catching `-1' return values. This change makes the conversion
    explicitly `int32'.

    R=rsc, rminnich, npe, r
    CC=golang-dev
    http://codereview.appspot.com/6576057

    Committer: Rob Pike <r@golang.org>


    http://codereview.appspot.com/6576057/
  • R at Sep 28, 2012 at 12:02 am

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 27, '12 at 11:54p
activeSep 28, '12 at 12:02a
posts3
users2
websitegolang.org

2 users in discussion

R: 2 posts Seed: 1 post

People

Translate

site design / logo © 2022 Grokbase