http://codereview.appspot.com/6554067/diff/20/src/pkg/reflect/example_test.go
File src/pkg/reflect/example_test.go (right):
http://codereview.appspot.com/6554067/diff/20/src/pkg/reflect/example_test.go#newcode24
src/pkg/reflect/example_test.go:24: // into Values, calls swap, and then
turns swaps result slice
On 2012/09/23 20:41:25, r wrote:
s/swaps/swap's/
Done.s/swaps/swap's/
http://codereview.appspot.com/6554067/diff/20/src/pkg/reflect/example_test.go#newcode39
src/pkg/reflect/example_test.go:39: // Make and call an int-valued swap
function.
On 2012/09/23 20:41:25, r wrote:
the swap function isn't int-valued, its arguments are.
// Make and call a swap function for ints.
Done.the swap function isn't int-valued, its arguments are.
// Make and call a swap function for ints.
http://codereview.appspot.com/6554067/diff/20/src/pkg/reflect/example_test.go#newcode44
src/pkg/reflect/example_test.go:44: // Make a float64-valued swap
function.
On 2012/09/23 20:41:25, r wrote:
// Make and call a swap function for float64s.
Done.// Make and call a swap function for float64s.
http://codereview.appspot.com/6554067/diff/20/src/pkg/reflect/makefunc.go
File src/pkg/reflect/makefunc.go (right):
http://codereview.appspot.com/6554067/diff/20/src/pkg/reflect/makefunc.go#newcode18
src/pkg/reflect/makefunc.go:18: // The code holds the same references.
On 2012/09/23 20:41:25, r wrote:
which code? be clear.
Done.which code? be clear.
http://codereview.appspot.com/6554067/diff/20/src/pkg/reflect/makefunc.go#newcode22
src/pkg/reflect/makefunc.go:22: // code is the actual machine code
invoked for the function.
On 2012/09/23 20:41:25, r wrote:
which function? be clear.
Done.which function? be clear.
http://codereview.appspot.com/6554067/diff/20/src/pkg/reflect/makefunc.go#newcode31
src/pkg/reflect/makefunc.go:31: // - return the values listed in out.
On 2012/09/23 20:41:25, r wrote:
'in' is a bad choice of name here. so is list.
- convert its arguments to a slice of Values, args.
- run results := fn(args)
- returns the results as a slice of Values, one per formal result.
Done.'in' is a bad choice of name here. so is list.
- convert its arguments to a slice of Values, args.
- run results := fn(args)
- returns the results as a slice of Values, one per formal result.
http://codereview.appspot.com/6554067/diff/20/src/pkg/reflect/makefunc.go#newcode31
src/pkg/reflect/makefunc.go:31: // - return the values listed in out.
On 2012/09/23 20:41:25, r wrote:
'in' is a bad choice of name here. so is list.
- convert its arguments to a slice of Values, args.
- run results := fn(args)
- returns the results as a slice of Values, one per formal result.
Done.'in' is a bad choice of name here. so is list.
- convert its arguments to a slice of Values, args.
- run results := fn(args)
- returns the results as a slice of Values, one per formal result.
http://codereview.appspot.com/6554067/diff/20/src/pkg/reflect/makefunc.go#newcode36
src/pkg/reflect/makefunc.go:36: // a slice representing the variadic
arguments, like in the
On 2012/09/23 20:41:25, r wrote:
s/like/as/
Done.s/like/as/
http://codereview.appspot.com/6554067/diff/20/src/pkg/reflect/makefunc.go#newcode45
src/pkg/reflect/makefunc.go:45: // See the example for <WHAT GOES HERE>?
On 2012/09/23 20:41:25, r wrote:
// The Examples section of the documentation includes an illustration of
// how to use MakeFunc to build a swap function for different types.
(you might even be able to make a useful URL here - not sure)
Done.// The Examples section of the documentation includes an illustration of
// how to use MakeFunc to build a swap function for different types.
(you might even be able to make a useful URL here - not sure)
http://codereview.appspot.com/6554067/diff/20/src/pkg/reflect/makefunc.go#newcode47
src/pkg/reflect/makefunc.go:47: func MakeFunc(typ Type, fn func(in
[]Value) (out []Value)) Value {
On 2012/09/23 20:41:25, r wrote:
s/in/args/
s/out/results/
Done.s/in/args/
s/out/results/
http://codereview.appspot.com/6554067/
