FAQ
is there urgent need for this? i don't have this itch to scratch.

if it cannot wait for improved representation of function values, please
park it somewhere self-contained.

on a different topic, i worry about the generic abuse this will
encourage.


http://codereview.appspot.com/6554067/diff/11/src/pkg/reflect/value.go
File src/pkg/reflect/value.go (right):

http://codereview.appspot.com/6554067/diff/11/src/pkg/reflect/value.go#newcode627
src/pkg/reflect/value.go:627: // results returned to the caller.
this still isn't clear because the words are hard to follow and because
the function is a small part of a longer story that is what we want to
do. for instance, there are slices involved but no indication about how
the slices relate in the multiple functions involved. i believe you
really want an example here. at least point to where an example can be
found.

http://codereview.appspot.com/6554067/diff/11/src/pkg/reflect/value.go#newcode727
src/pkg/reflect/value.go:727: 0xe59f000c, // MOVW 0x14(PC), R0
can we at least put all this ugliness, including MakeFunc, into a
separate file? it's jarring, plus i believe it will all be rewritten if
we change the representation of function values. here we have
hexadecimal instruction decodes immediately before the clean, simple
implementation of Cap. worlds are colliding.

http://codereview.appspot.com/6554067/

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 23, '12 at 1:07a
activeSep 23, '12 at 8:42p
posts10
users4
websitegolang.org

People

Translate

site design / logo © 2022 Grokbase