FAQ

Unfortunately this hint does not work if the change is *only* for commit
description.
The tool ended up creating empty updates to the code review list for
each attempt and crashing mercurial in the process - another bug :(
Finally managed to do so with some work-arounds.
Please raise a bug for this, hg change works on *nix systems.

Search Discussions

  • Shivakumar Gn at Sep 22, 2012 at 6:55 pm

    On 2012/09/22 11:59:08, dfc wrote:
    hg change 6555049
    will let you edit the CL description
    then hg mail 6555049
    http://golang.org/doc/contribute.html#tmp_65

    Unfortunately this hint does not work if the change is *only* for commit
    description.
    The tool ended up creating empty updates to the code review list for
    each attempt and crashing mercurial in the process - another bug :(
    Finally managed to do so with some work-arounds.


    http://codereview.appspot.com/6555049/
  • Shivakumar Gn at Sep 22, 2012 at 6:55 pm

    On 2012/09/22 13:51:28, dfc wrote:

    Please raise a bug for this, hg change works on *nix systems.

    Will do so. Please note that I have deleted the *empty* patchsets that
    had got created due to the tool bug.
    The patchset that was LGTMed is still available here for integration.


    http://codereview.appspot.com/6555049/
  • Shivakumar Gn at Sep 22, 2012 at 6:55 pm
    Hello golang-dev@googlegroups.com, minux.ma@gmail.com, dave@cheney.net
    (cc: golang-dev@googlegroups.com),

    Please take another look.


    http://codereview.appspot.com/6555049/
  • Minux Ma at Sep 24, 2012 at 8:47 am
    Any more comments about this CL?

    I will wait for 1 day before submitting.

    http://codereview.appspot.com/6555049/
  • R at Sep 24, 2012 at 9:48 am
    LGTM
    make sure he's in the CLA


    http://codereview.appspot.com/6555049/
  • Shivakumar Gn at Sep 24, 2012 at 3:31 pm

    On 2012/09/24 09:40:21, r wrote:
    LGTM
    make sure he's in the CLA
    I have signed(submitted) the Individual CLA.


    http://codereview.appspot.com/6555049/
  • Minux Ma at Sep 26, 2012 at 5:51 pm
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=b6d8227d99ae ***

    codereview: use subprocess.call() instead of os.spawnvp() for
    portability

    Fixes issue 4121.

    R=golang-dev, minux.ma, dave, r
    CC=golang-dev
    http://codereview.appspot.com/6555049

    Committer: Shenghou Ma <minux.ma@gmail.com>


    http://codereview.appspot.com/6555049/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 22, '12 at 1:51p
activeSep 26, '12 at 5:51p
posts8
users4
websitegolang.org

People

Translate

site design / logo © 2022 Grokbase