FAQ
I'm a little skeptical that racewalk.c is correct. I don't see any kind
of generic traversal and yet so many nodes with subexpressions don't
walk into the subexpressions. What am I missing?



http://codereview.appspot.com/6497074/diff/15001/src/cmd/gc/racewalk.c
File src/cmd/gc/racewalk.c (right):

http://codereview.appspot.com/6497074/diff/15001/src/cmd/gc/racewalk.c#newcode80
src/cmd/gc/racewalk.c:80: default:
Unindent switch body 1 tab

http://codereview.appspot.com/6497074/diff/15001/src/cmd/gc/racewalk.c#newcode80
src/cmd/gc/racewalk.c:80: default:
Why do you have a default and all the other cases explicitly enumerated?
I could see saying default: fatal("racewalk %O", n->op) or something
like that. But if you have default: goto ret, then all the other case
FOO: goto ret are unnecessary, no?

http://codereview.appspot.com/6497074/diff/15001/src/cmd/gc/racewalk.c#newcode96
src/cmd/gc/racewalk.c:96: case OCALL:
There sure are a lot of these. Might as well merge them all into one
case list instead of having lots of different case lists that all do
nothing.

http://codereview.appspot.com/6497074/

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 20, '12 at 6:00p
activeSep 20, '12 at 6:00p
posts1
users1
websitegolang.org

1 user in discussion

Rsc: 1 post

People

Translate

site design / logo © 2022 Grokbase