FAQ
Reviewers: golang-dev_googlegroups.com,

Description:
http://code.google.com/p/go/issues/detail?id=4064

Creating this manually through the rietveld UI, because
mercurial on gLucid is Too Damn Old. Sorry for any fail!

Please review this at https://codereview.appspot.com/6503100/

Affected files:
src/pkg/time/zoneinfo_read.go


Index: src/pkg/time/zoneinfo_read.go
===================================================================
--- src/pkg/time/zoneinfo_read.go Thu Jun 14 12:50:42 2012 +1000
+++ src/pkg/time/zoneinfo_read.go Tue Sep 11 17:22:03 2012 +0100
@@ -173,6 +173,10 @@
tx[i].isutc = isutc[i] != 0
}
}
+ if len(tx) == 0 {
+ // Fake up a single transition a-la FixedZone()
+ tx = append(tx, zoneTrans{-1 << 63, 0, false, false})
+ }

// Commited to succeed.
l = &Location{zone: zone, tx: tx}

Search Discussions

  • Russ Cox at Sep 17, 2012 at 9:12 pm
    Rietveld is unhappy with showing side-by-side diffs. I'll leave this
    for me or whoever ends up fixing 4064, so we can grab this code and
    then add a test too.

    Thanks again.
    Russ
  • Alex Bramley at Sep 18, 2012 at 8:40 am
    In order to get rietveld to accept my patch upload I had to munge it to SVN
    format (as, apparently, upload.py does), but I suspect I got the
    combination of the "base" field and the diff paths incorrect, which has
    deeply confused it ;-)

    Sorry for the confusion!
    --alex

    On 17 September 2012 22:12, Russ Cox wrote:

    Rietveld is unhappy with showing side-by-side diffs. I'll leave this
    for me or whoever ends up fixing 4064, so we can grab this code and
    then add a test too.

    Thanks again.
    Russ

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 11, '12 at 8:43p
activeSep 18, '12 at 8:40a
posts3
users2
websitegolang.org

2 users in discussion

Alex Bramley: 2 posts Russ Cox: 1 post

People

Translate

site design / logo © 2022 Grokbase