FAQ
Reviewers: rsc, r,

Message:
Hello rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go


Description:
exp/types/staging: operands, constants, and error handling

More pieces of the typechecker code:

- Operands are tempororary objects representing an expressions's
type and value (for constants). An operand is the equivalent of
an "attribute" in attribute grammars except that it's not stored
but only passed around during type checking.

- Constant operations are implemented in const.go. Constants are
represented as bool (booleans), int64 and *big.Int (integers),
*big.Rat (floats), complex (complex numbers), and string (strings).

- Error reporting is consolidated in errors.go. Only the first
dozen of lines is new code, the rest of the file contains the
exprString and typeString functions formerly in two separate
files (which have been removed).

Please review this at http://codereview.appspot.com/6492101/

Affected files:
A src/pkg/exp/types/staging/check.go
A src/pkg/exp/types/staging/const.go
A src/pkg/exp/types/staging/errors.go
R src/pkg/exp/types/staging/exprstring.go
A src/pkg/exp/types/staging/operand.go
M src/pkg/exp/types/staging/types.go
R src/pkg/exp/types/staging/typestring.go
M src/pkg/exp/types/staging/universe.go

Search Discussions

  • Robert Griesemer at Sep 12, 2012 at 4:42 am
    Replaced with equivalent URL: http://codereview.appspot.com/650011.
    - gri

    On Mon, Sep 10, 2012 at 3:48 PM, wrote:

    Reviewers: rsc, r,

    Message:
    Hello rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com),

    I'd like you to review this change to
    https://code.google.com/p/go


    Description:
    exp/types/staging: operands, constants, and error handling

    More pieces of the typechecker code:

    - Operands are tempororary objects representing an expressions's
    type and value (for constants). An operand is the equivalent of
    an "attribute" in attribute grammars except that it's not stored
    but only passed around during type checking.

    - Constant operations are implemented in const.go. Constants are
    represented as bool (booleans), int64 and *big.Int (integers),
    *big.Rat (floats), complex (complex numbers), and string (strings).

    - Error reporting is consolidated in errors.go. Only the first
    dozen of lines is new code, the rest of the file contains the
    exprString and typeString functions formerly in two separate
    files (which have been removed).

    Please review this at http://codereview.appspot.com/**6492101/<http://codereview.appspot.com/6492101/>

    Affected files:
    A src/pkg/exp/types/staging/**check.go
    A src/pkg/exp/types/staging/**const.go
    A src/pkg/exp/types/staging/**errors.go
    R src/pkg/exp/types/staging/**exprstring.go
    A src/pkg/exp/types/staging/**operand.go
    M src/pkg/exp/types/staging/**types.go
    R src/pkg/exp/types/staging/**typestring.go
    M src/pkg/exp/types/staging/**universe.go

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 10, '12 at 10:48p
activeSep 12, '12 at 4:42a
posts2
users1
websitegolang.org

1 user in discussion

Robert Griesemer: 2 posts

People

Translate

site design / logo © 2022 Grokbase