FAQ
On 2012/09/03 11:33:49, dfc wrote:


http://codereview.appspot.com/6426047/diff/37001/src/pkg/net/iprawsock_posix.go#newcode146
src/pkg/net/iprawsock_posix.go:146: func (c *IPConn) WriteMsgIP(b, oob []byte,
addr *IPAddr) (n, oobn int, err error) {
These return arguments are never set within the method, I don't think they are
helpful.
just for godoc, readability, doesn't make sense?

http://codereview.appspot.com/6426047/

Search Discussions

  • Dave at Sep 7, 2012 at 9:22 am
    LGTM. As this is an addition to the public API, I suggest waiting for
    one of the authors.


    http://codereview.appspot.com/6426047/diff/37001/src/pkg/net/iprawsock_posix.go
    File src/pkg/net/iprawsock_posix.go (right):

    http://codereview.appspot.com/6426047/diff/37001/src/pkg/net/iprawsock_posix.go#newcode146
    src/pkg/net/iprawsock_posix.go:146: func (c *IPConn) WriteMsgIP(b, oob
    []byte, addr *IPAddr) (n, oobn int, err error) {
    On 2012/09/03 11:33:49, dfc wrote:
    These return arguments are never set within the method, I don't think they are
    helpful.
    Fair enough. My concern was the return values are never assigned, new
    values are always returned.

    http://codereview.appspot.com/6426047/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 7, '12 at 8:16a
activeSep 7, '12 at 9:22a
posts2
users2
websitegolang.org

2 users in discussion

Dave: 1 post Mikioh Mikioh: 1 post

People

Translate

site design / logo © 2022 Grokbase