FAQ

Search Discussions

  • Dave at Sep 3, 2012 at 11:00 am

    On 2012/09/01 14:40:45, gobot wrote:
    R=rsc (assigned by rsc)
    I'm concerned that the version of these methods that is moving into
    go.net/ipv4, CL 6482044, are missing the calls to fd.incref()/decref().
    Is this no longer needed ?

    http://codereview.appspot.com/6497044/
  • Mikio Hara at Sep 3, 2012 at 11:51 am

    On Mon, Sep 3, 2012 at 8:00 PM, wrote:

    I'm concerned that the version of these methods that is moving into
    go.net/ipv4, CL 6482044, are missing the calls to fd.incref()/decref().
    Is this no longer needed ?
    My guess is that both fd.incref/decref are just for closing multiple socket
    read/writers, network I/O goroutines, on the same socket gracefully.
    So we probably might drop fd.incref/decref from socket option handlers
    in net package.
  • Dave at Sep 5, 2012 at 10:31 am

    My guess is that both fd.incref/decref are just for closing multiple socket
    read/writers, network I/O goroutines, on the same socket gracefully.
    So we probably might drop fd.incref/decref from socket option handlers
    in net package.
    From my reading this evening I believe incref/decref are primarily to
    prevent a fd being closed while there is a pending (ie, in the
    pollserver) Read/Write operation waiting on the underlying socket to
    become ready. In that context it is probably ok to skip these calls for
    setsocketopt type operations if the caller is prepared to deal with
    errors if the socket is closed concurrently.



    http://codereview.appspot.com/6497044/
  • Dave at Sep 5, 2012 at 10:40 am
  • Rsc at Sep 10, 2012 at 4:13 pm
    LGTM

    I'm surprised we had all this dead code lying around but...


    http://codereview.appspot.com/6497044/
  • Mikioh Mikioh at Sep 10, 2012 at 11:56 pm
    *** Submitted as
    http://code.google.com/p/go/source/detail?r=872a70417273 ***

    net: delete unused IP-level socket option helpers

    R=rsc, dave
    CC=bradfitz, gobot, golang-dev
    http://codereview.appspot.com/6497044


    http://codereview.appspot.com/6497044/

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 1, '12 at 2:40p
activeSep 10, '12 at 11:56p
posts7
users4
websitegolang.org

People

Translate

site design / logo © 2022 Grokbase