FAQ
Seems good. Please keep using the same runtime.write that was there, and
then call runtime.exit(1).

Normally you'd want runtime.throw for fatal errors like this, but you're
running on a non-Go stack so there is very little that is safe to do.



https://codereview.appspot.com/6498057/diff/7001/src/pkg/runtime/thread_openbsd.c
File src/pkg/runtime/thread_openbsd.c (right):

https://codereview.appspot.com/6498057/diff/7001/src/pkg/runtime/thread_openbsd.c#newcode240
src/pkg/runtime/thread_openbsd.c:240: /* Ignore SIGPROFs intended for a
non-Go thread. */
return
}

No else.

http://golang.org/doc/effective_go.html#if

https://codereview.appspot.com/6498057/

Search Discussions

  • Adonovan at Aug 31, 2012 at 6:10 pm
    Hello iant@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com),

    Please take another look.


    http://codereview.appspot.com/6498057/
  • Russ Cox at Aug 31, 2012 at 7:17 pm
    LGTM

    I added you to the list of committers. You should be able to submit
    this change yourself after following the directions at
    http://swtch.com/~rsc/gohg.html.

    Russ

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedAug 31, '12 at 5:43p
activeAug 31, '12 at 7:17p
posts3
users2
websitegolang.org

2 users in discussion

Russ Cox: 2 posts Adonovan: 1 post

People

Translate

site design / logo © 2021 Grokbase