Grokbase › Groups › Drupal › development › April 2007
FAQ
Hi all. I'm doing a drupal 5.1 Oracle db experimental port. I have a
first core installation more or less working.

Next target will be cck and views.

One problem was the need to remove the db_num_rows calls (unavailable in
Oracle). I've seen here and there an inappropriate use of this function
("select *" and db_num_rows in place of "select count(*)"), and I think
my patches can be useful also for performance under other databases.

I'll be glad to submit my patches. In case, tell me the best way to do
so, I'm new to the drupal project.

Best regards,
Gabriele Turchi

P.S.: I'm sorry, my english il alpha version...

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6054 bytes
Desc: not available
Url : http://lists.drupal.org/pipermail/development/attachments/20070407/1f9a6561/attachment-0001.bin

Search Discussions

  • Dries Buytaert at Apr 7, 2007 at 9:26 pm ⇧
    Hi Gabrieli,
    On 07 Apr 2007, at 10:40, Gabriele Turchi wrote:
    Hi all. I'm doing a drupal 5.1 Oracle db experimental port. I have a
    first core installation more or less working.

    Next target will be cck and views.

    One problem was the need to remove the db_num_rows calls
    (unavailable in
    Oracle). I've seen here and there an inappropriate use of this
    function
    ("select *" and db_num_rows in place of "select count(*)"), and I
    think
    my patches can be useful also for performance under other databases.
    Cool! :)

    Note that we can't commit your patch to the Drupal 5 branch -- only
    bugfixes are committed to that branch. You'll want to provide
    patches for CVS HEAD so that the new functionality can become part of
    Drupal 6.

    You'll want to check with Larry Garfield -- he's working on PDO
    support for Drupal 6, and is also looking into removing db_num_rows
    (). See this week's thread about "PDO and database limitations" for
    more information.

    Hope that helps and looking forward to your contributions,

    --
    Dries Buytaert :: http://www.buytaert.net/
  • Nicolas Tostin at Apr 9, 2007 at 3:10 pm ⇧
    You may be intersted in checking previous work done a while ago.
    http://drupal.org/node/87073
    http://drupal.org/node/39260
    http://www.oracle.com/technology/pub/articles/pedros-drupal.html

    Good to see new hands on it ;)

    ----- Original Message -----
    From: "Dries Buytaert" <dries.buytaert at gmail.com>
    To: <development at drupal.org>
    Sent: Saturday, April 07, 2007 4:26 PM
    Subject: Re: [development] Oracle porting & db_num_rows patches

    Hi Gabrieli,
    On 07 Apr 2007, at 10:40, Gabriele Turchi wrote:
    Hi all. I'm doing a drupal 5.1 Oracle db experimental port. I have a
    first core installation more or less working.
    Cool! :)
  • Larry Garfield at Apr 9, 2007 at 5:31 pm ⇧

    On Sat, 7 Apr 2007 23:26:55 +0200, Dries Buytaert wrote:
    Hi Gabrieli,
    On 07 Apr 2007, at 10:40, Gabriele Turchi wrote:
    Hi all. I'm doing a drupal 5.1 Oracle db experimental port. I have a
    first core installation more or less working.

    Next target will be cck and views.

    One problem was the need to remove the db_num_rows calls
    (unavailable in
    Oracle). I've seen here and there an inappropriate use of this
    function
    ("select *" and db_num_rows in place of "select count(*)"), and I
    think
    my patches can be useful also for performance under other databases.
    Cool! :)

    Note that we can't commit your patch to the Drupal 5 branch -- only
    bugfixes are committed to that branch. You'll want to provide
    patches for CVS HEAD so that the new functionality can become part of
    Drupal 6.

    You'll want to check with Larry Garfield -- he's working on PDO
    support for Drupal 6, and is also looking into removing db_num_rows
    (). See this week's thread about "PDO and database limitations" for
    more information.
    @Gabrieli: Greetings! Hopefully what I'm working on will make Oracle support easier, too.

    @Dries: Since it looks like db_num_rows() is going to be an issue for more than just PDO, would you be open to separate patches that just do "SQL cleanup" to eliminate db_num_rows(), clean up tablename-in-prepared-statement problems, etc, either as lots of little patches (my preference, easier to test/debug) or a big cleanup patch? I believe that will be the largest remaining part of PDO anyway, but valuable to native-Oracle efforts etc. as well.

    --Larry Garfield
  • Gabriele Turchi at Apr 10, 2007 at 6:56 am ⇧

    Il giorno lun, 09/04/2007 alle 12.31 -0500, Larry Garfield ha scritto:
    On Sat, 7 Apr 2007 23:26:55 +0200, Dries Buytaert wrote:
    Hi Gabrieli,
    On 07 Apr 2007, at 10:40, Gabriele Turchi wrote:
    Hi all. I'm doing a drupal 5.1 Oracle db experimental port. I have a
    first core installation more or less working.

    Next target will be cck and views.

    One problem was the need to remove the db_num_rows calls
    (unavailable in
    Oracle). I've seen here and there an inappropriate use of this
    function
    ("select *" and db_num_rows in place of "select count(*)"), and I
    think
    my patches can be useful also for performance under other databases.
    Cool! :)

    Note that we can't commit your patch to the Drupal 5 branch -- only
    bugfixes are committed to that branch. You'll want to provide
    patches for CVS HEAD so that the new functionality can become part of
    Drupal 6.

    You'll want to check with Larry Garfield -- he's working on PDO
    support for Drupal 6, and is also looking into removing db_num_rows
    (). See this week's thread about "PDO and database limitations" for
    more information.
    @Gabrieli: Greetings! Hopefully what I'm working on will make Oracle
    support easier, too.
    I think that too.
    @Dries: Since it looks like db_num_rows() is going to be an issue for
    more than just PDO, would you be open to separate patches that just
    do "SQL cleanup" to eliminate db_num_rows(), clean up
    tablename-in-prepared-statement problems, etc, either as lots of little
    patches (my preference, easier to test/debug) or a big cleanup patch?
    I believe that will be the largest remaining part of PDO anyway, but
    valuable to native-Oracle efforts etc. as well.
    To be honest, the big part of my patches about db_num_rows are
    one-liner... (change the select using "count(*)" where only the record
    number is needed and turning upside-down a while loop when fetching
    data).

    Maybe, creating some sort of "semi-official" patches should be useful to
    do something like a "beta-test" during the "5." release.

    About changes, may I also add a "we don't really need a kilometer-long
    table and index names"? Oracle doesn't like that...
    --Larry Garfield
    Best regards,
    Gabriele

    P.S.: I'm sorry, my english is alpha version...
    -------------- next part --------------
    A non-text attachment was scrubbed...
    Name: smime.p7s
    Type: application/x-pkcs7-signature
    Size: 6054 bytes
    Desc: not available
    Url : http://lists.drupal.org/pipermail/development/attachments/20070410/32932153/attachment-0001.bin

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdevelopment @
categoriesdrupal
postedApr 7, '07 at 8:40a
activeApr 10, '07 at 6:56a
posts5
users4
websitedrupal.org
irc#drupal

4 users in discussion

Gabriele Turchi: 2 posts Larry Garfield: 1 post Dries Buytaert: 1 post Nicolas Tostin: 1 post

Content

People

Support

Translate

site design / logo © 2023 Grokbase