Hi all,

Running:

http://archive.dojotoolkit.org/nightly/dojotoolkit/dojo/tests/parser.html

I get:

GET http://archive.dojotoolkit.org/nightly/dojotoolkit/dojo/tests/resources/AMDWidget
404 (Not Found)

I guess it worked at some point, so there might be a loader
regression? Or maybe the test never worked ;)

--
Christophe

Search Discussions

  • Kitson Kelly at Jan 19, 2012 at 1:03 pm
    Bill corrected that in http://bugs.dojotoolkit.org/changeset/27565/dojo,
    don't know why it isn't in nightly.
    On 19 January 2012 17:34, Christophe Jolif wrote:

    Hi all,

    Running:

    http://archive.dojotoolkit.org/nightly/dojotoolkit/dojo/tests/parser.html

    I get:

    GET
    http://archive.dojotoolkit.org/nightly/dojotoolkit/dojo/tests/resources/AMDWidget
    404 (Not Found)

    I guess it worked at some point, so there might be a loader
    regression? Or maybe the test never worked ;)

    --
    Christophe
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
    -------------- next part --------------
    An HTML attachment was scrubbed...
    URL: http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20120119/244cd7cd/attachment.htm
  • Christophe Jolif at Jan 20, 2012 at 3:43 am
    Thanks Kitson but I pointed to the nightly build for convenience so
    that anyone can try quickly, but I do reproduce with a local checkout.
    Don't you?

    Note that Bill commit is correctly reflected in nightly build see:

    http://archive.dojotoolkit.org/nightly/dojotoolkit/dojo/tests/resources/

    2012/1/19 Kitson Kelly <kitson.kelly at asseverate.co.uk>:
    Bill corrected that in?http://bugs.dojotoolkit.org/changeset/27565/dojo,
    don't know why it isn't in nightly.
    On 19 January 2012 17:34, Christophe Jolif wrote:

    Hi all,

    Running:

    http://archive.dojotoolkit.org/nightly/dojotoolkit/dojo/tests/parser.html

    I get:

    GET
    http://archive.dojotoolkit.org/nightly/dojotoolkit/dojo/tests/resources/AMDWidget
    404 (Not Found)

    I guess it worked at some point, so there might be a loader
    regression? Or maybe the test never worked ;)

    --
    Christophe
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors


    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors


    --
    Christophe
  • Kitson Kelly at Jan 20, 2012 at 4:21 am
    No, it is in my local checkout... I have SVN revision 27565 for my /dojo
    and it is in there at the moment (which happens to be the revision that the
    file was introduced). There was a gap, where Bill missed the file, so in
    theory you could be on a revision that didn't have the file, but the
    changes to the test.
    On 20 January 2012 08:43, Christophe Jolif wrote:

    Thanks Kitson but I pointed to the nightly build for convenience so
    that anyone can try quickly, but I do reproduce with a local checkout.
    Don't you?

    Note that Bill commit is correctly reflected in nightly build see:

    http://archive.dojotoolkit.org/nightly/dojotoolkit/dojo/tests/resources/

    2012/1/19 Kitson Kelly <kitson.kelly at asseverate.co.uk>:
    Bill corrected that in http://bugs.dojotoolkit.org/changeset/27565/dojo,
    don't know why it isn't in nightly.
    On 19 January 2012 17:34, Christophe Jolif wrote:

    Hi all,

    Running:
    http://archive.dojotoolkit.org/nightly/dojotoolkit/dojo/tests/parser.html
    I get:

    GET
    http://archive.dojotoolkit.org/nightly/dojotoolkit/dojo/tests/resources/AMDWidget
    404 (Not Found)

    I guess it worked at some point, so there might be a loader
    regression? Or maybe the test never worked ;)

    --
    Christophe
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors


    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors


    --
    Christophe
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
    -------------- next part --------------
    An HTML attachment was scrubbed...
    URL: http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20120120/201f5a6f/attachment.htm
  • Christophe Jolif at Jan 20, 2012 at 4:32 am
    I _do_ have the file. But still the loader fails...

    2012/1/20 Kitson Kelly <kitson.kelly at asseverate.co.uk>:
    No, it is in my local checkout... ?I have SVN revision 27565 for my /dojo
    and it is in there at the moment (which happens to be the revision that the
    file was introduced). ?There was a gap, where Bill missed the file, so in
    theory you could be on a revision that didn't have the file, but the changes
    to the test.
    On 20 January 2012 08:43, Christophe Jolif wrote:

    Thanks Kitson but I pointed to the nightly build for convenience so
    that anyone can try quickly, but I do reproduce with a local checkout.
    Don't you?

    Note that Bill commit is correctly reflected in nightly build see:

    http://archive.dojotoolkit.org/nightly/dojotoolkit/dojo/tests/resources/

    2012/1/19 Kitson Kelly <kitson.kelly at asseverate.co.uk>:
    Bill corrected that in?http://bugs.dojotoolkit.org/changeset/27565/dojo,
    don't know why it isn't in nightly.
    On 19 January 2012 17:34, Christophe Jolif wrote:

    Hi all,

    Running:


    http://archive.dojotoolkit.org/nightly/dojotoolkit/dojo/tests/parser.html

    I get:

    GET

    http://archive.dojotoolkit.org/nightly/dojotoolkit/dojo/tests/resources/AMDWidget
    404 (Not Found)

    I guess it worked at some point, so there might be a loader
    regression? Or maybe the test never worked ;)

    --
    Christophe
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors


    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors


    --
    Christophe
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors


    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors


    --
    Christophe
  • Kitson Kelly at Jan 20, 2012 at 4:39 am
    Oh, you are right, but for some reason it is working on my local checkout.

    I think it is working on Bill's too... But I looked on my local machine
    and I see that my local HTTP server is doing a GET of AMDWidget (without
    the .js) and it is returning the file, but I did the following in the Unit
    Test:

    require([...,"./resources/AMDWidget",...],...)


    I didn't realise require to a relative path doesn't auto append the .js
    when fetching a resource, so depending on how the webserver is configured,
    it sometimes finds the resource and sometimes doesn't. Does anyone know if
    that is intentional by the loader? I guess what I should do is not use a
    relative path. I will make the change and add it to the ticket.
    On 20 January 2012 09:32, Christophe Jolif wrote:

    I _do_ have the file. But still the loader fails...
    -------------- next part --------------
    An HTML attachment was scrubbed...
    URL: http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20120120/d3e7c154/attachment.htm
  • Kitson Kelly at Jan 20, 2012 at 4:50 am
    Ok, I have put the patch with the ticket:
    http://bugs.dojotoolkit.org/ticket/13778. Still curious if it is
    intentional with relative modules that the .js extension is not used.
    On 20 January 2012 09:39, Kitson Kelly wrote:

    Oh, you are right, but for some reason it is working on my local checkout.

    I think it is working on Bill's too... But I looked on my local machine
    and I see that my local HTTP server is doing a GET of AMDWidget (without
    the .js) and it is returning the file, but I did the following in the Unit
    Test:

    require([...,"./resources/AMDWidget",...],...)


    I didn't realise require to a relative path doesn't auto append the .js
    when fetching a resource, so depending on how the webserver is configured,
    it sometimes finds the resource and sometimes doesn't. Does anyone know if
    that is intentional by the loader? I guess what I should do is not use a
    relative path. I will make the change and add it to the ticket.
    -------------- next part --------------
    An HTML attachment was scrubbed...
    URL: http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20120120/5954831b/attachment.htm
  • Bill Keese at Jan 20, 2012 at 5:50 am
    That was a weird one, thanks to both of you for finding and fixing the bug.
    (I'll check in that patch.)

    2012/1/20 Kitson Kelly <kitson.kelly at asseverate.co.uk>
    Ok, I have put the patch with the ticket:
    http://bugs.dojotoolkit.org/ticket/13778. Still curious if it is
    intentional with relative modules that the .js extension is not used.
    On 20 January 2012 09:39, Kitson Kelly wrote:

    Oh, you are right, but for some reason it is working on my local checkout.

    I think it is working on Bill's too... But I looked on my local machine
    and I see that my local HTTP server is doing a GET of AMDWidget (without
    the .js) and it is returning the file, but I did the following in the Unit
    Test:

    require([...,"./resources/AMDWidget",...],...)


    I didn't realise require to a relative path doesn't auto append the .js
    when fetching a resource, so depending on how the webserver is configured,
    it sometimes finds the resource and sometimes doesn't. Does anyone know if
    that is intentional by the loader? I guess what I should do is not use a
    relative path. I will make the change and add it to the ticket.
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
    -------------- next part --------------
    An HTML attachment was scrubbed...
    URL: http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20120120/56ac12ae/attachment.htm
  • Ben hockey at Jan 20, 2012 at 9:21 am
    when the global require is used, there is no reference module in play
    for calculating relative module ids. in the code, this puts you into
    this block
    http://bugs.dojotoolkit.org/browser/dojo/tags/release-1.7.1/dojo/dojo.js#L831

    at that point, it treats the mid as an url. i'm wondering if it should
    append .js when isRelative && !referenceModule is true?

    i'm not certain its wrong but if you want to open a ticket on it then
    you can see what rawld thinks.

    ben...
    On 1/20/2012 4:50 AM, Kitson Kelly wrote:
    Ok, I have put the patch with the ticket:
    http://bugs.dojotoolkit.org/ticket/13778. Still curious if it is
    intentional with relative modules that the .js extension is not used.

    On 20 January 2012 09:39, Kitson Kelly <kitson.kelly at asseverate.co.uk
    wrote:

    Oh, you are right, but for some reason it is working on my local
    checkout.

    I think it is working on Bill's too... But I looked on my local
    machine and I see that my local HTTP server is doing a GET of
    AMDWidget (without the .js) and it is returning the file, but I
    did the following in the Unit Test:

    require([...,"./resources/AMDWidget",...],...)


    I didn't realise require to a relative path doesn't auto append
    the .js when fetching a resource, so depending on how the
    webserver is configured, it sometimes finds the resource and
    sometimes doesn't. Does anyone know if that is intentional by the
    loader? I guess what I should do is not use a relative path. I
    will make the change and add it to the ticket.



    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
    -------------- next part --------------
    An HTML attachment was scrubbed...
    URL: http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20120120/f25de5a0/attachment-0001.htm
  • Kitson Kelly at Jan 20, 2012 at 9:35 am
    Worth the question... #14649 <http://bugs.dojotoolkit.org/ticket/14649>filed.
    On 20 January 2012 14:21, ben hockey wrote:

    when the global require is used, there is no reference module in play for
    calculating relative module ids. in the code, this puts you into this
    block
    http://bugs.dojotoolkit.org/browser/dojo/tags/release-1.7.1/dojo/dojo.js#L831

    at that point, it treats the mid as an url. i'm wondering if it should
    append .js when isRelative && !referenceModule is true?

    i'm not certain its wrong but if you want to open a ticket on it then you
    can see what rawld thinks.

    ben...


    On 1/20/2012 4:50 AM, Kitson Kelly wrote:

    Ok, I have put the patch with the ticket:
    http://bugs.dojotoolkit.org/ticket/13778. Still curious if it is
    intentional with relative modules that the .js extension is not used.
    On 20 January 2012 09:39, Kitson Kelly wrote:

    Oh, you are right, but for some reason it is working on my local checkout.

    I think it is working on Bill's too... But I looked on my local
    machine and I see that my local HTTP server is doing a GET of AMDWidget
    (without the .js) and it is returning the file, but I did the following in
    the Unit Test:

    require([...,"./resources/AMDWidget",...],...)


    I didn't realise require to a relative path doesn't auto append the .js
    when fetching a resource, so depending on how the webserver is configured,
    it sometimes finds the resource and sometimes doesn't. Does anyone know if
    that is intentional by the loader? I guess what I should do is not use a
    relative path. I will make the change and add it to the ticket.
    _______________________________________________
    dojo-contributors mailing listdojo-contributors at mail.dojotoolkit.orghttp://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors


    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
    -------------- next part --------------
    An HTML attachment was scrubbed...
    URL: http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20120120/690a38bb/attachment.htm

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdojo-contributors @
categoriesdojo
postedJan 19, '12 at 12:34p
activeJan 20, '12 at 9:35a
posts10
users4
websitedojotoolkit.org

People

Translate

site design / logo © 2021 Grokbase