So we're currently at 4 bugs on the hotlist:
http://tinyurl.com/6kaqy6a and I'm aware of one loader issue which
rawld will soon file a ticket and patch for -- I don't understand the
details, but it kept my large-ish legacy app from running, so I'd
argue for an rc2 for that alone as it might impact others.

There are 4 other tickets on the hotlist. If we're going to do an
rc2, it would be good to do ASAP.

#14019 The 1.7 docscripts does not generate the doc for properties

Is there a solution or patch pending? What is the impact and timing?

#12451 Event handling improvements

I believe this should be closed. If there are any new issues, they
should be filed as new tickets.

#13957 Doh selfTest problem

Rhino test issue. Ben has a patch ready to go. If there's an rc2,
might as well apply it, once reviewed by Kris? Does anyone know how
to get the Dojo core Rhino DOH tests to run?

#14064 CLDR data regression on 1.7

Also an issue with Rhino support. I could integrate this with an
rc2 with relatively low-risk, but I'm also ok if people think it
should wait until 1.7.1. I created a 1.7.1 milestone in trac for
scheduling.

Anything else?

-Adam

Search Discussions

  • Ben hockey at Oct 17, 2011 at 3:25 pm

    On 10/17/2011 3:10 PM, Adam Peller wrote:
    Does anyone know how
    to get the Dojo core Rhino DOH tests to run?
    i can't get the tests to pass (didn't examine the output to see why) but
    i can get them to run with node (from util/doh)
    node ../../dojo/dojo.js baseUrl=../../dojo load=doh
    test=dojo/tests/module

    the command to run with rhino (from util/doh) is
    ./runner.sh test=dojo/tests/module

    but things explode when i try it.

    ben...
  • Ben hockey at Oct 17, 2011 at 3:29 pm
    if there's an RC2 i think these 2 are easy fixes that could be included
    with very low risk:

    #14100 - dojox/gfx/svg, changing if ('r' in this.shape) to if
    (this.shape.r != null) to stop undefined and null values passing
    #14089 - the build uses some hard coded values for the build report
    file but was supposed to use some config data.

    i just need the project owners to give the ok.

    ben...
    On 10/17/2011 3:10 PM, Adam Peller wrote:
    So we're currently at 4 bugs on the hotlist:
    http://tinyurl.com/6kaqy6a and I'm aware of one loader issue which
    rawld will soon file a ticket and patch for -- I don't understand the
    details, but it kept my large-ish legacy app from running, so I'd
    argue for an rc2 for that alone as it might impact others.

    There are 4 other tickets on the hotlist. If we're going to do an
    rc2, it would be good to do ASAP.

    #14019 The 1.7 docscripts does not generate the doc for properties

    Is there a solution or patch pending? What is the impact and timing?

    #12451 Event handling improvements

    I believe this should be closed. If there are any new issues, they
    should be filed as new tickets.

    #13957 Doh selfTest problem

    Rhino test issue. Ben has a patch ready to go. If there's an rc2,
    might as well apply it, once reviewed by Kris? Does anyone know how
    to get the Dojo core Rhino DOH tests to run?

    #14064 CLDR data regression on 1.7

    Also an issue with Rhino support. I could integrate this with an
    rc2 with relatively low-risk, but I'm also ok if people think it
    should wait until 1.7.1. I created a 1.7.1 milestone in trac for
    scheduling.

    Anything else?

    -Adam
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
  • Patrick Ruzand at Oct 18, 2011 at 11:57 am

    On Mon, Oct 17, 2011 at 9:29 PM, ben hockey wrote:
    if there's an RC2 i think these 2 are easy fixes that could be included
    with very low risk:

    ? ? #14100 - dojox/gfx/svg, changing if ('r' in this.shape) to if
    (this.shape.r != null) to stop undefined and null values passing [...]
    ? ? #14089 - the build uses some hard coded values for the build report
    file but was supposed to use some config data.

    i just need the project owners to give the ok.

    ben...
    This is indeed a regression introduced by my #13406 patch.
    As far as I am concerned, I'm ok with your fix.
    Patrick

    PS: is there a way to get automatically notified of new tickets
    targeting a specific module (i.e. dojox.gfx)
  • Ben hockey at Oct 18, 2011 at 12:10 pm

    On 10/18/2011 11:57 AM, Patrick Ruzand wrote:
    This is indeed a regression introduced by my #13406 patch.
    As far as I am concerned, I'm ok with your fix.
    Patrick

    PS: is there a way to get automatically notified of new tickets
    targeting a specific module (i.e. dojox.gfx)
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
    thanks patrick - fixed in r26881. i'm not completely familiar with trac
    to know if you can setup notifications but i know that the component
    owner is notified whenever a ticket is created. for gfx, the owner is
    currently listed as eugene. should this be changed?

    ben...
  • Patrick Ruzand at Oct 18, 2011 at 12:16 pm

    PS: is there a way to get automatically notified of new tickets
    targeting a specific module (i.e. dojox.gfx)
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
    thanks patrick - fixed in r26881. ?i'm not completely familiar with trac
    to know if you can setup notifications but i know that the component
    owner is notified whenever a ticket is created. ?for gfx, the owner is
    currently listed as eugene. should this be changed?
    No no, gfx owner is still Eugene :) . I will explore my trac profile,
    maybe there's something.

    Thanks

    Patrick
  • Rawld Gill at Oct 17, 2011 at 7:44 pm
    I just fixed a fairly tricky bug in the loader backcompat when loading built,
    legacy, apps. (Adam found the problem last week in the maqetta project.) You
    can read all about it here:

    http://trac.dojotoolkit.org/ticket/14109

    Anybody building apps that have lots of legacy modules should give them a try.

    --Rawld

    more, inline, below
    On Monday, October 17, 2011 03:10:46 PM Adam Peller wrote:
    So we're currently at 4 bugs on the hotlist:
    http://tinyurl.com/6kaqy6a and I'm aware of one loader issue which
    rawld will soon file a ticket and patch for -- I don't understand the
    details, but it kept my large-ish legacy app from running, so I'd
    argue for an rc2 for that alone as it might impact others.

    There are 4 other tickets on the hotlist. If we're going to do an
    rc2, it would be good to do ASAP.

    #14019 The 1.7 docscripts does not generate the doc for properties

    Is there a solution or patch pending? What is the impact and timing?

    #12451 Event handling improvements

    I believe this should be closed. If there are any new issues, they
    should be filed as new tickets.

    #13957 Doh selfTest problem

    Rhino test issue. Ben has a patch ready to go. If there's an rc2,
    might as well apply it, once reviewed by Kris? Does anyone know how
    to get the Dojo core Rhino DOH tests to run?

    #14064 CLDR data regression on 1.7

    I can look into this later tonight.
    Also an issue with Rhino support. I could integrate this with an
    rc2 with relatively low-risk, but I'm also ok if people think it
    should wait until 1.7.1. I created a 1.7.1 milestone in trac for
    scheduling.

    Anything else?

    -Adam
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
  • Adam Peller at Oct 19, 2011 at 10:38 am
    Only ticket left is #14019. Any status?

    Might as well wait until #dojo-meeting to cut rc2. If anything else
    needs to go in, speak up now.

    -Adam
    On Mon, Oct 17, 2011 at 3:10 PM, Adam Peller wrote:
    So we're currently at 4 bugs on the hotlist:
    http://tinyurl.com/6kaqy6a and I'm aware of one loader issue which
    rawld will soon file a ticket and patch for -- I don't understand the
    details, but it kept my large-ish legacy app from running, so I'd
    argue for an rc2 for that alone as it might impact others.

    There are 4 other tickets on the hotlist. ?If we're going to do an
    rc2, it would be good to do ASAP.

    #14019 ?The 1.7 docscripts does not generate the doc for properties

    ?Is there a solution or patch pending? ?What is the impact and timing?

    #12451 ?Event handling improvements

    ?I believe this should be closed. ?If there are any new issues, they
    should be filed as new tickets.

    #13957 ?Doh selfTest problem

    ?Rhino test issue. Ben has a patch ready to go. ?If there's an rc2,
    might as well apply it, once reviewed by Kris? ?Does anyone know how
    to get the Dojo core Rhino DOH tests to run?

    #14064 ?CLDR data regression on 1.7

    ?Also an issue with Rhino support. ?I could integrate this with an
    rc2 with relatively low-risk, but I'm also ok if people think it
    should wait until 1.7.1. ?I created a 1.7.1 milestone in trac for
    scheduling.

    Anything else?

    -Adam
  • Evan Huang at Oct 20, 2011 at 8:46 am
    I fired a new ticket today when dealing with #14110 -
    http://bugs.dojotoolkit.org/ticket/14128 there seems to be a
    regression in our build system cascading css import url(...) are
    pulled in and flattened across different files, though I marked it as
    high, but not sure it shall really block our rc2.

    Any clues for this issue or anything I've missed?

    Thanks!
    - Evan
    On Wed, Oct 19, 2011 at 10:38 PM, Adam Peller wrote:
    Only ticket left is #14019. ?Any status?

    Might as well wait until #dojo-meeting to cut rc2. ?If anything else
    needs to go in, speak up now.

    -Adam
    On Mon, Oct 17, 2011 at 3:10 PM, Adam Peller wrote:
    So we're currently at 4 bugs on the hotlist:
    http://tinyurl.com/6kaqy6a and I'm aware of one loader issue which
    rawld will soon file a ticket and patch for -- I don't understand the
    details, but it kept my large-ish legacy app from running, so I'd
    argue for an rc2 for that alone as it might impact others.

    There are 4 other tickets on the hotlist. ?If we're going to do an
    rc2, it would be good to do ASAP.

    #14019 ?The 1.7 docscripts does not generate the doc for properties

    ?Is there a solution or patch pending? ?What is the impact and timing?

    #12451 ?Event handling improvements

    ?I believe this should be closed. ?If there are any new issues, they
    should be filed as new tickets.

    #13957 ?Doh selfTest problem

    ?Rhino test issue. Ben has a patch ready to go. ?If there's an rc2,
    might as well apply it, once reviewed by Kris? ?Does anyone know how
    to get the Dojo core Rhino DOH tests to run?

    #14064 ?CLDR data regression on 1.7

    ?Also an issue with Rhino support. ?I could integrate this with an
    rc2 with relatively low-risk, but I'm also ok if people think it
    should wait until 1.7.1. ?I created a 1.7.1 milestone in trac for
    scheduling.

    Anything else?

    -Adam
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
  • Ben hockey at Oct 20, 2011 at 9:16 am
    #14108 is another bug about css and building - it seems related. i'm
    going to bump up the priority on #14108 as well.

    ben...
    On 10/20/2011 8:46 AM, Evan Huang wrote:
    I fired a new ticket today when dealing with #14110 -
    http://bugs.dojotoolkit.org/ticket/14128 there seems to be a
    regression in our build system cascading css import url(...) are
    pulled in and flattened across different files, though I marked it as
    high, but not sure it shall really block our rc2.

    Any clues for this issue or anything I've missed?

    Thanks!
    - Evan
  • Mike Wilcox at Oct 20, 2011 at 9:37 am
    I can confirm the css build bugs, and talked to Rawld about them last week (he sounded extraordinarily busy btw). The fix to combine the files is not too hard (I have a fix, but it may be more of a hack) - but the fix to resolve the background-image urls does not look easy, and the mechanism for gathering the images into a "built" folder is no where to be found.

    Mike Wilcox
    http://clubajax.org
    mike at mikewilcox.net


    On Oct 20, 2011, at 8:16 AM, ben hockey wrote:

    #14108 is another bug about css and building - it seems related. i'm
    going to bump up the priority on #14108 as well.

    ben...
    On 10/20/2011 8:46 AM, Evan Huang wrote:
    I fired a new ticket today when dealing with #14110 -
    http://bugs.dojotoolkit.org/ticket/14128 there seems to be a
    regression in our build system cascading css import url(...) are
    pulled in and flattened across different files, though I marked it as
    high, but not sure it shall really block our rc2.

    Any clues for this issue or anything I've missed?

    Thanks!
    - Evan
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
  • Rawld Gill at Oct 20, 2011 at 11:34 pm

    On Thursday, October 20, 2011 08:37:25 AM Mike Wilcox wrote:
    I can confirm the css build bugs, and talked to Rawld about them last week
    (he sounded extraordinarily busy btw). The fix to combine the files is not
    too hard (I have a fix, but it may be more of a hack) -
    could you post to the ticket. I'll review and commit.
    but the fix to
    resolve the background-image urls does not look easy, and the mechanism for
    gathering the images into a "built" folder is no where to be found
    Could you explain more. If the background image is in the source tree, it's
    copied and is available to copy someplace else.

    Thanks,
    Rawld
  • Mike Wilcox at Oct 23, 2011 at 9:06 am
    Sorry this took so long.

    I've attached a patched to #14108 that creates a resource from the @imports which allows them to be built into single files.

    Still outstanding though is that the background images do not resolve. There is code in the optimizeCss transform to do it, but it always points to the original dojo location, not to the build location, so I don't think it works and I can't figure out how it is intended to work. Also, iirc, the old build tool collected all the images used and put them in a new folder. Relatedly, I haven't been able to get any of my custom code app images to move (I even tried targeting them with a package). I usually have an img folder in my css folder, and it does not copy over; I tried adding "css/img":1 into the copyOnly function in my profile which did not work.

    Mike Wilcox
    http://clubajax.org
    mike at mikewilcox.net


    On Oct 20, 2011, at 10:34 PM, Rawld Gill wrote:
    On Thursday, October 20, 2011 08:37:25 AM Mike Wilcox wrote:
    I can confirm the css build bugs, and talked to Rawld about them last week
    (he sounded extraordinarily busy btw). The fix to combine the files is not
    too hard (I have a fix, but it may be more of a hack) -
    could you post to the ticket. I'll review and commit.
    but the fix to
    resolve the background-image urls does not look easy, and the mechanism for
    gathering the images into a "built" folder is no where to be found
    Could you explain more. If the background image is in the source tree, it's
    copied and is available to copy someplace else.

    Thanks,
    Rawld


    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
  • Ben hockey at Oct 24, 2011 at 10:14 am
    for #14108 there was a much simpler fix. the problem was that
    dojo/resources/dojo.css was being marked as copyOnly and that's why
    there was no importContents for that file. if rawld would do a sanity
    check on the patch i've inlined at
    http://bugs.dojotoolkit.org/ticket/14108#comment:6 then we can probably
    close #14108.

    i'm going to look at #14128 next to see if i can find the issue related
    to paths not adjusting properly. in order to get this fixed asap, it
    wouldn't hurt for others to be looking into the issue at the same time -
    ie if you're inclined to look at the problem too, don't stop just
    because i'm looking into it.

    ben...
    On 10/23/2011 9:06 AM, Mike Wilcox wrote:
    Sorry this took so long.

    I've attached a patched to #14108 that creates a resource from the @imports which allows them to be built into single files.

    Still outstanding though is that the background images do not resolve. There is code in the optimizeCss transform to do it, but it always points to the original dojo location, not to the build location, so I don't think it works and I can't figure out how it is intended to work. Also, iirc, the old build tool collected all the images used and put them in a new folder. Relatedly, I haven't been able to get any of my custom code app images to move (I even tried targeting them with a package). I usually have an img folder in my css folder, and it does not copy over; I tried adding "css/img":1 into the copyOnly function in my profile which did not work.

    Mike Wilcox
    http://clubajax.org
    mike at mikewilcox.net


    On Oct 20, 2011, at 10:34 PM, Rawld Gill wrote:
    On Thursday, October 20, 2011 08:37:25 AM Mike Wilcox wrote:
    I can confirm the css build bugs, and talked to Rawld about them last week
    (he sounded extraordinarily busy btw). The fix to combine the files is not
    too hard (I have a fix, but it may be more of a hack) -
    could you post to the ticket. I'll review and commit.
    but the fix to
    resolve the background-image urls does not look easy, and the mechanism for
    gathering the images into a "built" folder is no where to be found
    Could you explain more. If the background image is in the source tree, it's
    copied and is available to copy someplace else.

    Thanks,
    Rawld


    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
  • Rawld Gill at Oct 24, 2011 at 12:16 pm
    Thanks Ben. I just committed a fix. I changed the filter expr slightly so that
    a few other files would be allowed through the copyOnly filter (like LICENSE).
    Also checked dijig (fixed), dojox (was OK), and demos (fixed).
    On Monday, October 24, 2011 10:14:32 AM ben hockey wrote:
    for #14108 there was a much simpler fix. the problem was that
    dojo/resources/dojo.css was being marked as copyOnly and that's why
    there was no importContents for that file. if rawld would do a sanity
    check on the patch i've inlined at
    http://bugs.dojotoolkit.org/ticket/14108#comment:6 then we can probably
    close #14108.

    i'm going to look at #14128 next to see if i can find the issue related
    to paths not adjusting properly. in order to get this fixed asap, it
    wouldn't hurt for others to be looking into the issue at the same time -
    ie if you're inclined to look at the problem too, don't stop just
    because i'm looking into it.

    ben...
    On 10/23/2011 9:06 AM, Mike Wilcox wrote:
    Sorry this took so long.

    I've attached a patched to #14108 that creates a resource from the
    @imports which allows them to be built into single files.

    Still outstanding though is that the background images do not resolve.
    There is code in the optimizeCss transform to do it, but it always
    points to the original dojo location, not to the build location, so I
    don't think it works and I can't figure out how it is intended to work.
    Also, iirc, the old build tool collected all the images used and put
    them in a new folder. Relatedly, I haven't been able to get any of my
    custom code app images to move (I even tried targeting them with a
    package). I usually have an img folder in my css folder, and it does
    not copy over; I tried adding "css/img":1 into the copyOnly function in
    my profile which did not work.

    Mike Wilcox
    http://clubajax.org
    mike at mikewilcox.net
    On Oct 20, 2011, at 10:34 PM, Rawld Gill wrote:
    On Thursday, October 20, 2011 08:37:25 AM Mike Wilcox wrote:
    I can confirm the css build bugs, and talked to Rawld about them
    last week (he sounded extraordinarily busy btw). The fix to
    combine the files is not too hard (I have a fix, but it may be more
    of a hack) -
    could you post to the ticket. I'll review and commit.
    but the fix to
    resolve the background-image urls does not look easy, and the
    mechanism for gathering the images into a "built" folder is no
    where to be found>>
    Could you explain more. If the background image is in the source tree,
    it's copied and is available to copy someplace else.

    Thanks,
    Rawld


    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
    -------------- next part --------------
    An HTML attachment was scrubbed...
    URL: http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20111024/a85b1500/attachment.htm
  • Ben hockey at Oct 24, 2011 at 1:01 pm
    looks good.
    On 10/24/2011 12:16 PM, Rawld Gill wrote:

    Thanks Ben. I just committed a fix. I changed the filter expr slightly
    so that a few other files would be allowed through the copyOnly filter
    (like LICENSE). Also checked dijig (fixed), dojox (was OK), and demos
    (fixed).
    On Monday, October 24, 2011 10:14:32 AM ben hockey wrote:

    for #14108 there was a much simpler fix. the problem was that
    dojo/resources/dojo.css was being marked as copyOnly and that's why
    there was no importContents for that file. if rawld would do a sanity
    check on the patch i've inlined at
    http://bugs.dojotoolkit.org/ticket/14108#comment:6 then we can probably
    close #14108.

    i'm going to look at #14128 next to see if i can find the issue related
    to paths not adjusting properly. in order to get this fixed asap, it
    wouldn't hurt for others to be looking into the issue at the same time -
    ie if you're inclined to look at the problem too, don't stop just
    because i'm looking into it.

    ben...

    On 10/23/2011 9:06 AM, Mike Wilcox wrote:

    Sorry this took so long.
    I've attached a patched to #14108 that creates a resource from the
    @imports which allows them to be built into single files.
    Still outstanding though is that the background images do not resolve.
    There is code in the optimizeCss transform to do it, but it always
    points to the original dojo location, not to the build location, so I
    don't think it works and I can't figure out how it is intended to
    work.
    Also, iirc, the old build tool collected all the images used and put
    them in a new folder. Relatedly, I haven't been able to get any of my
    custom code app images to move (I even tried targeting them with a
    package). I usually have an img folder in my css folder, and it does
    not copy over; I tried adding "css/img":1 into the copyOnly
    function in
    my profile which did not work.
    Mike Wilcox
    mike at mikewilcox.net

    On Oct 20, 2011, at 10:34 PM, Rawld Gill wrote:
    On Thursday, October 20, 2011 08:37:25 AM Mike Wilcox wrote:

    I can confirm the css build bugs, and talked to Rawld about them
    last week (he sounded extraordinarily busy btw). The fix to
    combine the files is not too hard (I have a fix, but it may be more
    of a hack) -
    could you post to the ticket. I'll review and commit.

    but the fix to
    resolve the background-image urls does not look easy, and the
    mechanism for gathering the images into a "built" folder is no
    where to be found>>
    Could you explain more. If the background image is in the source
    tree,
    it's copied and is available to copy someplace else.
    Thanks,
    Rawld
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org

    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors


    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
    -------------- next part --------------
    An HTML attachment was scrubbed...
    URL: http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20111024/9b974545/attachment-0001.htm
  • Ben hockey at Oct 24, 2011 at 1:44 pm
    rawld - please check, fix for #14128
    http://bugs.dojotoolkit.org/ticket/14128#comment:5

    ben...
    On 10/24/2011 12:16 PM, Rawld Gill wrote:

    Thanks Ben. I just committed a fix. I changed the filter expr slightly
    so that a few other files would be allowed through the copyOnly filter
    (like LICENSE). Also checked dijig (fixed), dojox (was OK), and demos
    (fixed).
    On Monday, October 24, 2011 10:14:32 AM ben hockey wrote:

    for #14108 there was a much simpler fix. the problem was that
    dojo/resources/dojo.css was being marked as copyOnly and that's why
    there was no importContents for that file. if rawld would do a sanity
    check on the patch i've inlined at
    http://bugs.dojotoolkit.org/ticket/14108#comment:6 then we can probably
    close #14108.

    i'm going to look at #14128 next to see if i can find the issue related
    to paths not adjusting properly. in order to get this fixed asap, it
    wouldn't hurt for others to be looking into the issue at the same time -
    ie if you're inclined to look at the problem too, don't stop just
    because i'm looking into it.

    ben...

    On 10/23/2011 9:06 AM, Mike Wilcox wrote:

    Sorry this took so long.
    I've attached a patched to #14108 that creates a resource from the
    @imports which allows them to be built into single files.
    Still outstanding though is that the background images do not resolve.
    There is code in the optimizeCss transform to do it, but it always
    points to the original dojo location, not to the build location, so I
    don't think it works and I can't figure out how it is intended to
    work.
    Also, iirc, the old build tool collected all the images used and put
    them in a new folder. Relatedly, I haven't been able to get any of my
    custom code app images to move (I even tried targeting them with a
    package). I usually have an img folder in my css folder, and it does
    not copy over; I tried adding "css/img":1 into the copyOnly
    function in
    my profile which did not work.
    Mike Wilcox
    mike at mikewilcox.net

    On Oct 20, 2011, at 10:34 PM, Rawld Gill wrote:
    On Thursday, October 20, 2011 08:37:25 AM Mike Wilcox wrote:

    I can confirm the css build bugs, and talked to Rawld about them
    last week (he sounded extraordinarily busy btw). The fix to
    combine the files is not too hard (I have a fix, but it may be more
    of a hack) -
    could you post to the ticket. I'll review and commit.

    but the fix to
    resolve the background-image urls does not look easy, and the
    mechanism for gathering the images into a "built" folder is no
    where to be found>>
    Could you explain more. If the background image is in the source
    tree,
    it's copied and is available to copy someplace else.
    Thanks,
    Rawld
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org

    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors


    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
    -------------- next part --------------
    An HTML attachment was scrubbed...
    URL: http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20111024/656b92f5/attachment.htm
  • Ben hockey at Oct 24, 2011 at 3:02 pm
    rawld,

    it looks like making fileUtils just like dojo.js should fix #14128
    http://bugs.dojotoolkit.org/ticket/14128#comment:10

    sorry for the noise in that ticket - i was seeing changes on the surface
    that looked good and then when i'd look deeper i'd see that the fix was
    incomplete or had bugs of its own.

    ben...
    On 10/24/2011 12:16 PM, Rawld Gill wrote:

    Thanks Ben. I just committed a fix. I changed the filter expr slightly
    so that a few other files would be allowed through the copyOnly filter
    (like LICENSE). Also checked dijig (fixed), dojox (was OK), and demos
    (fixed).
    On Monday, October 24, 2011 10:14:32 AM ben hockey wrote:

    for #14108 there was a much simpler fix. the problem was that
    dojo/resources/dojo.css was being marked as copyOnly and that's why
    there was no importContents for that file. if rawld would do a sanity
    check on the patch i've inlined at
    http://bugs.dojotoolkit.org/ticket/14108#comment:6 then we can probably
    close #14108.

    i'm going to look at #14128 next to see if i can find the issue related
    to paths not adjusting properly. in order to get this fixed asap, it
    wouldn't hurt for others to be looking into the issue at the same time -
    ie if you're inclined to look at the problem too, don't stop just
    because i'm looking into it.

    ben...

    On 10/23/2011 9:06 AM, Mike Wilcox wrote:

    Sorry this took so long.
    I've attached a patched to #14108 that creates a resource from the
    @imports which allows them to be built into single files.
    Still outstanding though is that the background images do not resolve.
    There is code in the optimizeCss transform to do it, but it always
    points to the original dojo location, not to the build location, so I
    don't think it works and I can't figure out how it is intended to
    work.
    Also, iirc, the old build tool collected all the images used and put
    them in a new folder. Relatedly, I haven't been able to get any of my
    custom code app images to move (I even tried targeting them with a
    package). I usually have an img folder in my css folder, and it does
    not copy over; I tried adding "css/img":1 into the copyOnly
    function in
    my profile which did not work.
    Mike Wilcox
    mike at mikewilcox.net

    On Oct 20, 2011, at 10:34 PM, Rawld Gill wrote:
    On Thursday, October 20, 2011 08:37:25 AM Mike Wilcox wrote:

    I can confirm the css build bugs, and talked to Rawld about them
    last week (he sounded extraordinarily busy btw). The fix to
    combine the files is not too hard (I have a fix, but it may be more
    of a hack) -
    could you post to the ticket. I'll review and commit.

    but the fix to
    resolve the background-image urls does not look easy, and the
    mechanism for gathering the images into a "built" folder is no
    where to be found>>
    Could you explain more. If the background image is in the source
    tree,
    it's copied and is available to copy someplace else.
    Thanks,
    Rawld
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org

    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors


    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
    -------------- next part --------------
    An HTML attachment was scrubbed...
    URL: http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20111024/b207deb7/attachment-0001.htm

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdojo-contributors @
categoriesdojo
postedOct 17, '11 at 3:10p
activeOct 24, '11 at 3:02p
posts18
users6
websitedojotoolkit.org

People

Translate

site design / logo © 2022 Grokbase