Hi,

under IE 8, loading dojox/gfx/tests/svgweb/test_gfx.html (all svgweb
tests in fact) throws an error in dojo/on l.159 :

if(target.addEventListener){
// the target has addEventListener, which[...snip...]
// check for capture conversions
var capture = type in captures; <<<<< captures is undefined ->
"Object expected" error.

the 'captures' variable initialization is done only if
has("dom-addeventlistener")) is true, which is not the case here.
The problem is that svgweb has added the missing addEventListener()
method to the target element (window), which in a way conflict with
the has(..) feature detection done previously, and therefore messes up
the on.js code flow, since it will detect here the addEventListener
method and assumes 'captures' is defined.
Maybe on.js should ensure the 'captures' variable is defined ?

(see http://code.google.com/p/svgweb/source/browse/trunk/src/svg.js?r89
l.2183 where the addEventListener extension is done)

Thanks,

--
Patrick

Search Discussions

  • Patrick Ruzand at Sep 1, 2011 at 9:16 am
    Hi,

    just to be sure it is not lost. All svgweb tests are currently broken with
    beta 5/IE8 because of this error thrown by dojo/on.

    Patrick
    On Wednesday, August 31, 2011, Patrick Ruzand wrote:

    Hi,

    under IE 8, loading dojox/gfx/tests/svgweb/test_gfx.html (all svgweb
    tests in fact) throws an error in dojo/on l.159 :

    if(target.addEventListener){
    // the target has addEventListener, which[...snip...]
    // check for capture conversions
    var capture = type in captures; <<<<< captures is undefined ->
    "Object expected" error.

    the 'captures' variable initialization is done only if
    has("dom-addeventlistener")) is true, which is not the case here.
    The problem is that svgweb has added the missing addEventListener()
    method to the target element (window), which in a way conflict with
    the has(..) feature detection done previously, and therefore messes up
    the on.js code flow, since it will detect here the addEventListener
    method and assumes 'captures' is defined.
    Maybe on.js should ensure the 'captures' variable is defined ?

    (see http://code.google.com/p/svgweb/source/browse/trunk/src/svg.js?r89
    l.2183 where the addEventListener extension is done)

    Thanks,

    --
    Patrick

    --
    --
    Patrick
    -------------- next part --------------
    An HTML attachment was scrubbed...
    URL: http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20110901/1c4dd691/attachment.htm
  • Jared Jurkiewicz at Sep 1, 2011 at 10:05 am
    Have you opened a bug on http://bugs.dojotoolkit.org ?

    That's the best way to ensure it does not get lost.

    -- Jared

    2011/9/1 Patrick Ruzand <pruzand at gmail.com>:
    Hi,
    just to be sure it is not lost. All svgweb tests are currently broken with
    beta 5/IE8 because of this error thrown by dojo/on.
    Patrick
    On Wednesday, August 31, 2011, Patrick Ruzand wrote:

    Hi,

    under IE 8, loading ?dojox/gfx/tests/svgweb/test_gfx.html (all svgweb
    tests in fact) throws an error in dojo/on l.159 :

    if(target.addEventListener){
    ? ?// the target has addEventListener, which[...snip...]
    ? ?// check for capture conversions
    ? ?var capture = type in captures; ?<<<<< captures is undefined ->
    "Object expected" error.

    the 'captures' variable initialization is done only if
    has("dom-addeventlistener")) is true, which is not the case here.
    The problem is that svgweb has ?added the missing addEventListener()
    method to the target element (window), which in a way conflict with
    the has(..) feature detection done previously, and therefore messes up
    the on.js code flow, since it will detect here the addEventListener
    method and assumes 'captures' is defined.
    Maybe on.js should ensure the 'captures' variable is defined ?

    (see http://code.google.com/p/svgweb/source/browse/trunk/src/svg.js?r89
    l.2183 where the addEventListener extension is done)

    Thanks,

    --
    Patrick

    --
    --
    Patrick

    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
  • Patrick Ruzand at Sep 1, 2011 at 10:25 am
    Hi Jared,

    You 're right. So here it is:
    http://bugs.dojotoolkit.org/ticket/13803

    (was not sure of the procedure for the beta tests).

    Thx
    Patrick

    PS: note that I first created it as a gfx bug, so it has been assigned to
    Eugene. Then I moved it to Core (since it seems to be in dojo/on) but owner
    has not changed. Should I change it ?
    On Thursday, September 1, 2011, Jared Jurkiewicz wrote:

    Have you opened a bug on http://bugs.dojotoolkit.org ?

    That's the best way to ensure it does not get lost.

    -- Jared

    2011/9/1 Patrick Ruzand <pruzand at gmail.com <javascript:;>>:
    Hi,
    just to be sure it is not lost. All svgweb tests are currently broken with
    beta 5/IE8 because of this error thrown by dojo/on.
    Patrick
    On Wednesday, August 31, 2011, Patrick Ruzand wrote:

    Hi,

    under IE 8, loading dojox/gfx/tests/svgweb/test_gfx.html (all svgweb
    tests in fact) throws an error in dojo/on l.159 :

    if(target.addEventListener){
    // the target has addEventListener, which[...snip...]
    // check for capture conversions
    var capture = type in captures; <<<<< captures is undefined ->
    "Object expected" error.

    the 'captures' variable initialization is done only if
    has("dom-addeventlistener")) is true, which is not the case here.
    The problem is that svgweb has added the missing addEventListener()
    method to the target element (window), which in a way conflict with
    the has(..) feature detection done previously, and therefore messes up
    the on.js code flow, since it will detect here the addEventListener
    method and assumes 'captures' is defined.
    Maybe on.js should ensure the 'captures' variable is defined ?

    (see
    http://code.google.com/p/svgweb/source/browse/trunk/src/svg.js?r89
    l.2183 where the addEventListener extension is done)

    Thanks,

    --
    Patrick

    --
    --
    Patrick

    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org <javascript:;>
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org <javascript:;>
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors

    --
    --
    Patrick
    -------------- next part --------------
    An HTML attachment was scrubbed...
    URL: http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20110901/97b43eb4/attachment-0001.htm

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdojo-contributors @
categoriesdojo
postedAug 31, '11 at 9:29a
activeSep 1, '11 at 10:25a
posts4
users2
websitedojotoolkit.org

People

Translate

site design / logo © 2022 Grokbase