[dojo-contributors] DataGrid is broken by new attr() in _Widgets.js

On 4/1/10 12:13 PM, Wei CDL Huang wrote:

Hi,

DataGrid is broken by some changes in _Widget.js - data of new pages
are not getting loaded, pls see
http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/grid/tests/test_data_grid.html
<http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/grid/tests/test_data_grid.html>
(scroll to the bottom to see the issue)

The cause is the new implementation of attr() is explicitly invoking
get()/set() to fetch/set attributes, but unfortunately DataGrid has
also been using "get()" for another job - fetching items from data
store, and using "get=xxxx" for cell content rendering, the conflicts
causes the issue - attr() uses DataGrid's get() to fetch attributes,
then failed.

Just in case there are any similar potential bugs in other widgets.

- Evan


_______________________________________________
dojo-contributors mailing list
dojo-contributors at mail.dojotoolkit.org
http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors

On 4/1/2010 9:44 AM, Bill Keese wrote:
I checked and didn't see any other widgets defining get(). Still,
it's a disturbing problem.

Probably we should rename get() in DataGrid. I think it's just an
internal function? Other opinions?