Hi,

DataGrid is broken by some changes in _Widget.js - data of new pages are
not getting loaded, pls see
http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/grid/tests/test_data_grid.html
(scroll to the bottom to see the issue)

The cause is the new implementation of attr() is explicitly invoking
get()/set() to fetch/set attributes, but unfortunately DataGrid has also
been using "get()" for another job - fetching items from data store, and
using "get=xxxx" for cell content rendering, the conflicts causes the
issue - attr() uses DataGrid's get() to fetch attributes, then failed.

Just in case there are any similar potential bugs in other widgets.

- Evan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20100401/9655da35/attachment.htm

Search Discussions

  • Bill Keese at Apr 1, 2010 at 11:44 am
    I checked and didn't see any other widgets defining get(). Still, it's
    a disturbing problem.

    Probably we should rename get() in DataGrid. I think it's just an
    internal function? Other opinions?
    On 4/1/10 12:13 PM, Wei CDL Huang wrote:

    Hi,

    DataGrid is broken by some changes in _Widget.js - data of new pages
    are not getting loaded, pls see
    http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/grid/tests/test_data_grid.html
    <http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/grid/tests/test_data_grid.html>
    (scroll to the bottom to see the issue)

    The cause is the new implementation of attr() is explicitly invoking
    get()/set() to fetch/set attributes, but unfortunately DataGrid has
    also been using "get()" for another job - fetching items from data
    store, and using "get=xxxx" for cell content rendering, the conflicts
    causes the issue - attr() uses DataGrid's get() to fetch attributes,
    then failed.

    Just in case there are any similar potential bugs in other widgets.

    - Evan


    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors at mail.dojotoolkit.org
    http://mail.dojotoolkit.org/mailman/listinfo/dojo-contributors
    -------------- next part --------------
    An HTML attachment was scrubbed...
    URL: http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20100402/4ebcb2e2/attachment.htm
  • Kris Zyp at Apr 2, 2010 at 4:45 pm

    On 4/1/2010 9:44 AM, Bill Keese wrote:
    I checked and didn't see any other widgets defining get(). Still,
    it's a disturbing problem.

    Probably we should rename get() in DataGrid. I think it's just an
    internal function? Other opinions?
    I fixed get() so that it can handle string attributes in the normal attr
    style, and numeric attributes in the grid's special way. The get()
    function is bizarre though, it doesn't seem like it is supposed to be
    used directly, it is default function (gets copied there) for the
    dojox.grid.Cell class that is not a subclass of the Grid.
    Kris
    -------------- next part --------------
    An HTML attachment was scrubbed...
    URL: http://mail.dojotoolkit.org/pipermail/dojo-contributors/attachments/20100402/6e9d8357/attachment-0001.htm

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdojo-contributors @
categoriesdojo
postedMar 31, '10 at 11:13p
activeApr 2, '10 at 4:45p
posts3
users3
websitedojotoolkit.org

People

Translate

site design / logo © 2022 Grokbase