Hey fellow Dojo contributors,
I've put some finishing touches on the html-refactor branch (along with
merges from trunk) and I'm asking for one last round of tests in
preparation for a possible merge to trunk on Monday or Tuesday. One
note: I haven't separated what we talked about in the meeting as the
"presentation" layer. I figured we could tackle that beast once
html-refactor is merged back to trunk.
If all goes well, I'd like to request a freeze on code commits for an
hour on the day I do the merge to allow me to merge any pending changes
from trunk to html-refactor, and then merge html-refactor back onto
trunk. This will also give all developers the chance to update their
copy of trunk and resolve any conflicts they have in code they have yet
to commit so what I'm merging doesn't get overwritten.
Thanks to everyone that reviewed html-refactor the first time around.
It helped Tom and I out very much. Hopefully this time around we're
flawless ;).

--
======================================================================
Bryan Forbes
bryan@reigndropsfall.net
http://www.reigndropsfall.net

"It does not take a majority to prevail, but rather an irate, tireless
minority keen to set brush fires in people's minds."
- Samuel Adams, an architect of the Constitution

Key fingerprint = 3D7D B728 713A BB7B B8B1 5B61 3888 17E0 70CA 0F3D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : http://dojotoolkit.org/pipermail/dojo-contributors/attachments/20060716/9c537794/attachment.pgp

Search Discussions

  • Alex Russell at Jul 16, 2006 at 4:36 pm

    On Sunday 16 July 2006 1:39 pm, Bryan Forbes wrote:
    Hey fellow Dojo contributors,
    I've put some finishing touches on the html-refactor branch (along
    with merges from trunk) and I'm asking for one last round of tests in
    preparation for a possible merge to trunk on Monday or Tuesday. One
    note: I haven't separated what we talked about in the meeting as the
    "presentation" layer. I figured we could tackle that beast once
    html-refactor is merged back to trunk.
    Yes, I agree that should be separate and distinct.
    If all goes well, I'd like to request a freeze on code commits for
    an hour on the day I do the merge to allow me to merge any pending
    changes from trunk to html-refactor, and then merge html-refactor
    back onto trunk.
    It would be best if you just told us when not to commit. Otherwise
    asking for consensus on the time will take longer than the merge ;-)
    This will also give all developers the chance to
    update their copy of trunk and resolve any conflicts they have in
    code they have yet to commit so what I'm merging doesn't get
    overwritten. Yep.
    Thanks to everyone that reviewed html-refactor the first time
    around. It helped Tom and I out very much. Hopefully this time
    around we're flawless ;).
    Thank you guys for spending so much time and effort to make our
    dependencies saner and our builds smaller! It's non-trivial stuff and I
    think everyone is in your debt for taking it on.

    Regards

    --
    Alex Russell
    alex@sitepen.com A99F 8785 F491 D5FD 04D7 ACD9 4158 FFDF 2894 6876
    alex@dojotoolkit.org BE03 E88D EABB 2116 CC49 8259 CF78 E242 59C3 9723
    -------------- next part --------------
    A non-text attachment was scrubbed...
    Name: not available
    Type: application/pgp-signature
    Size: 188 bytes
    Desc: not available
    Url : http://dojotoolkit.org/pipermail/dojo-contributors/attachments/20060716/49b5ec20/attachment.pgp
  • Tom Trenka at Jul 16, 2006 at 6:02 pm
    To be honest all of the credos go to Bryan; I'm only wishing that this
    was an SoC project or something at this point, he's done some great
    work.

    trt
    On 7/16/06, Alex Russell wrote:
    On Sunday 16 July 2006 1:39 pm, Bryan Forbes wrote:
    Hey fellow Dojo contributors,
    I've put some finishing touches on the html-refactor branch (along
    with merges from trunk) and I'm asking for one last round of tests in
    preparation for a possible merge to trunk on Monday or Tuesday. One
    note: I haven't separated what we talked about in the meeting as the
    "presentation" layer. I figured we could tackle that beast once
    html-refactor is merged back to trunk.
    Yes, I agree that should be separate and distinct.
    If all goes well, I'd like to request a freeze on code commits for
    an hour on the day I do the merge to allow me to merge any pending
    changes from trunk to html-refactor, and then merge html-refactor
    back onto trunk.
    It would be best if you just told us when not to commit. Otherwise
    asking for consensus on the time will take longer than the merge ;-)
    This will also give all developers the chance to
    update their copy of trunk and resolve any conflicts they have in
    code they have yet to commit so what I'm merging doesn't get
    overwritten. Yep.
    Thanks to everyone that reviewed html-refactor the first time
    around. It helped Tom and I out very much. Hopefully this time
    around we're flawless ;).
    Thank you guys for spending so much time and effort to make our
    dependencies saner and our builds smaller! It's non-trivial stuff and I
    think everyone is in your debt for taking it on.

    Regards

    --
    Alex Russell
    alex@sitepen.com A99F 8785 F491 D5FD 04D7 ACD9 4158 FFDF 2894 6876
    alex@dojotoolkit.org BE03 E88D EABB 2116 CC49 8259 CF78 E242 59C3 9723


    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors@dojotoolkit.org
    http://dojotoolkit.org/mailman/listinfo/dojo-contributors


  • Bill Keese at Jul 16, 2006 at 7:28 pm

    Bryan Forbes wrote:
    Hey fellow Dojo contributors,
    I've put some finishing touches on the html-refactor branch (along with
    merges from trunk) and I'm asking for one last round of tests in
    preparation for a possible merge to trunk on Monday or Tuesday.
    Hi Bryan.

    1) Did you fix all the stuff I listed in my last mail?

    2) Did you write any documentation on the API changes? (I don't care so
    much about the packaging changes)

    3) What was the conclusion on standardizing member names? Is every
    return value like {x:10,y:20,w:30:h:40}?

    --

    Bill
  • Bryan Forbes at Jul 16, 2006 at 8:14 pm

    On Mon, 2006-07-17 at 10:28 +0900, Bill Keese wrote:
    Hi Bryan.

    1) Did you fix all the stuff I listed in my last mail?
    I think I did. I can't test the bugs in IE which is why I'm coming back
    to the list.
    2) Did you write any documentation on the API changes? (I don't care so
    much about the packaging changes)
    Not yet. I'm going to before I merge.
    3) What was the conclusion on standardizing member names? Is every
    return value like {x:10,y:20,w:30:h:40}?
    {x:10,y:20,left:10,y:20,width:30,height:40}
    We decided to duplicate x as left and y as right where it made sense
    because some people develop they layouts as top/left and some as x/y.
    If I missed a spot, let me know

    --
    ======================================================================
    Bryan Forbes
    bryan@reigndropsfall.net
    http://www.reigndropsfall.net

    "It does not take a majority to prevail, but rather an irate, tireless
    minority keen to set brush fires in people's minds."
    - Samuel Adams, an architect of the Constitution

    Key fingerprint = 3D7D B728 713A BB7B B8B1 5B61 3888 17E0 70CA 0F3D
    -------------- next part --------------
    A non-text attachment was scrubbed...
    Name: not available
    Type: application/pgp-signature
    Size: 191 bytes
    Desc: This is a digitally signed message part
    Url : http://dojotoolkit.org/pipermail/dojo-contributors/attachments/20060716/2470b766/attachment.pgp
  • Bill Keese at Jul 17, 2006 at 5:43 am
    OK, I'll take a look. Are there any functions that take an
    {x:10,y:20,left:10,y:20,width:30,height:40} type structure as input, and
    if so, which variables are required to be set? (x or left)

    Bryan Forbes wrote:
    On Mon, 2006-07-17 at 10:28 +0900, Bill Keese wrote:
    Hi Bryan.

    1) Did you fix all the stuff I listed in my last mail?
    I think I did. I can't test the bugs in IE which is why I'm coming back
    to the list.
    2) Did you write any documentation on the API changes? (I don't care so
    much about the packaging changes)
    Not yet. I'm going to before I merge.
    3) What was the conclusion on standardizing member names? Is every
    return value like {x:10,y:20,w:30:h:40}?
    {x:10,y:20,left:10,y:20,width:30,height:40}
    We decided to duplicate x as left and y as right where it made sense
    because some people develop they layouts as top/left and some as x/y.
    If I missed a spot, let me know



    ------------------------------------------------------------------------

    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors@dojotoolkit.org
    http://dojotoolkit.org/mailman/listinfo/dojo-contributors
    --

    Bill
  • Bryan Forbes at Jul 17, 2006 at 7:11 am
    I've changed the slideTo/slideBy methods to use top/left, but you can
    still pass in an array until 0.5. Also, setMarginBox and setContentBox
    take a width/height object.
    On Mon, 2006-07-17 at 20:44 +0900, Bill Keese wrote:
    OK, I'll take a look. Are there any functions that take an
    {x:10,y:20,left:10,y:20,width:30,height:40} type structure as input, and
    if so, which variables are required to be set? (x or left)

    Bryan Forbes wrote:
    On Mon, 2006-07-17 at 10:28 +0900, Bill Keese wrote:
    Hi Bryan.

    1) Did you fix all the stuff I listed in my last mail?
    I think I did. I can't test the bugs in IE which is why I'm coming back
    to the list.
    2) Did you write any documentation on the API changes? (I don't care so
    much about the packaging changes)
    Not yet. I'm going to before I merge.
    3) What was the conclusion on standardizing member names? Is every
    return value like {x:10,y:20,w:30:h:40}?
    {x:10,y:20,left:10,y:20,width:30,height:40}
    We decided to duplicate x as left and y as right where it made sense
    because some people develop they layouts as top/left and some as x/y.
    If I missed a spot, let me know



    ------------------------------------------------------------------------

    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors@dojotoolkit.org
    http://dojotoolkit.org/mailman/listinfo/dojo-contributors
    --
    ======================================================================
    Bryan Forbes
    bryan@reigndropsfall.net
    http://www.reigndropsfall.net

    "It does not take a majority to prevail, but rather an irate, tireless
    minority keen to set brush fires in people's minds."
    - Samuel Adams, an architect of the Constitution

    Key fingerprint = 3D7D B728 713A BB7B B8B1 5B61 3888 17E0 70CA 0F3D
    -------------- next part --------------
    A non-text attachment was scrubbed...
    Name: not available
    Type: application/pgp-signature
    Size: 191 bytes
    Desc: This is a digitally signed message part
    Url : http://dojotoolkit.org/pipermail/dojo-contributors/attachments/20060717/19684788/attachment.pgp
  • Bill Keese at Jul 16, 2006 at 7:29 pm

    Bryan Forbes wrote:
    I'm asking for one last round of tests in
    preparation for a possible merge to trunk on Monday or Tuesday.
    PS: maybe you should post two URLs (before and after) so people can
    easily test for regressions w/out having to check out the src.

    --

    Bill
  • Bryan Forbes at Jul 16, 2006 at 8:26 pm

    On Mon, 2006-07-17 at 10:30 +0900, Bill Keese wrote:

    PS: maybe you should post two URLs (before and after) so people can
    easily test for regressions w/out having to check out the src.
    http://www.reigndropsfall.net/refactor/before/tests/
    http://www.reigndropsfall.net/refactor/after/tests/

    Please don't hit it too much... I have a limited amount of bandwidth per
    month ;).

    --
    ======================================================================
    Bryan Forbes
    bryan@reigndropsfall.net
    http://www.reigndropsfall.net

    "It does not take a majority to prevail, but rather an irate, tireless
    minority keen to set brush fires in people's minds."
    - Samuel Adams, an architect of the Constitution

    Key fingerprint = 3D7D B728 713A BB7B B8B1 5B61 3888 17E0 70CA 0F3D
    -------------- next part --------------
    A non-text attachment was scrubbed...
    Name: not available
    Type: application/pgp-signature
    Size: 191 bytes
    Desc: This is a digitally signed message part
    Url : http://dojotoolkit.org/pipermail/dojo-contributors/attachments/20060716/a454d0a7/attachment.pgp
  • Dustin Machi at Jul 16, 2006 at 9:29 pm
    You do have an account on mastodon with a ~public_html directory for
    this purpose :)


    Bryan Forbes wrote:
    On Mon, 2006-07-17 at 10:30 +0900, Bill Keese wrote:

    PS: maybe you should post two URLs (before and after) so people can
    easily test for regressions w/out having to check out the src.
    http://www.reigndropsfall.net/refactor/before/tests/
    http://www.reigndropsfall.net/refactor/after/tests/

    Please don't hit it too much... I have a limited amount of bandwidth per
    month ;).



    ------------------------------------------------------------------------

    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors@dojotoolkit.org
    http://dojotoolkit.org/mailman/listinfo/dojo-contributors
  • Bryan Forbes at Jul 17, 2006 at 7:16 am
    With Dustin's suggestion, here are my dojotoolkit.org URLs:

    http://dojotoolkit.org/~BryanForbes/before/tests/
    http://dojotoolkit.org/~BryanForbes/after/tests/

    Hit these all you want ;).

    --
    ======================================================================
    Bryan Forbes
    bryan@reigndropsfall.net
    http://www.reigndropsfall.net

    "It does not take a majority to prevail, but rather an irate, tireless
    minority keen to set brush fires in people's minds."
    - Samuel Adams, an architect of the Constitution

    Key fingerprint = 3D7D B728 713A BB7B B8B1 5B61 3888 17E0 70CA 0F3D
    -------------- next part --------------
    A non-text attachment was scrubbed...
    Name: not available
    Type: application/pgp-signature
    Size: 191 bytes
    Desc: This is a digitally signed message part
    Url : http://dojotoolkit.org/pipermail/dojo-contributors/attachments/20060717/fed8362c/attachment.pgp
  • Bill Keese at Jul 17, 2006 at 7:47 am
    Thanks. I did some brief testing on IE, and apparently I keep hitting
    the same bug over and over again; makes it impossible to do further
    testing. All the bugs are about "w".

    1) test_Dialog.html is broken (press "show" --> javascript err)

    2) test_FloatingPane.html, test_RemotePane.html, test_TaskBar.html,
    dnd/test_dragdropparent.html gets javascript err on page load

    3) test_Toggler.html - press 3 button, same err as above

    Need to fix that error before I can continue testing.

    There were also a lot of other alarming bugs that occur in both trunk
    and the branch, but I didn't list them here.

    Bryan Forbes wrote:
    With Dustin's suggestion, here are my dojotoolkit.org URLs:

    http://dojotoolkit.org/~BryanForbes/before/tests/
    http://dojotoolkit.org/~BryanForbes/after/tests/

    Hit these all you want ;).



    ------------------------------------------------------------------------

    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors@dojotoolkit.org
    http://dojotoolkit.org/mailman/listinfo/dojo-contributors
    --

    Bill
  • Bryan Forbes at Jul 17, 2006 at 10:03 am
    Thanks for the bugs. I have them fixed and committed and the after link
    is updated.
    On Mon, 2006-07-17 at 22:48 +0900, Bill Keese wrote:
    Thanks. I did some brief testing on IE, and apparently I keep hitting
    the same bug over and over again; makes it impossible to do further
    testing. All the bugs are about "w".

    1) test_Dialog.html is broken (press "show" --> javascript err)

    2) test_FloatingPane.html, test_RemotePane.html, test_TaskBar.html,
    dnd/test_dragdropparent.html gets javascript err on page load

    3) test_Toggler.html - press 3 button, same err as above

    Need to fix that error before I can continue testing.

    There were also a lot of other alarming bugs that occur in both trunk
    and the branch, but I didn't list them here.

    Bryan Forbes wrote:
    With Dustin's suggestion, here are my dojotoolkit.org URLs:

    http://dojotoolkit.org/~BryanForbes/before/tests/
    http://dojotoolkit.org/~BryanForbes/after/tests/

    Hit these all you want ;).



    ------------------------------------------------------------------------

    _______________________________________________
    dojo-contributors mailing list
    dojo-contributors@dojotoolkit.org
    http://dojotoolkit.org/mailman/listinfo/dojo-contributors
    --
    ======================================================================
    Bryan Forbes
    bryan@reigndropsfall.net
    http://www.reigndropsfall.net

    "It does not take a majority to prevail, but rather an irate, tireless
    minority keen to set brush fires in people's minds."
    - Samuel Adams, an architect of the Constitution

    Key fingerprint = 3D7D B728 713A BB7B B8B1 5B61 3888 17E0 70CA 0F3D
    -------------- next part --------------
    A non-text attachment was scrubbed...
    Name: not available
    Type: application/pgp-signature
    Size: 191 bytes
    Desc: This is a digitally signed message part
    Url : http://dojotoolkit.org/pipermail/dojo-contributors/attachments/20060717/98f2716d/attachment.pgp

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdojo-contributors @
categoriesdojo
postedJul 16, '06 at 2:39p
activeJul 17, '06 at 10:03a
posts13
users5
websitedojotoolkit.org

People

Translate

site design / logo © 2021 Grokbase