FAQ
Hi,


attached are two patches to make the preupgrade assistant recognize
centos and actually do something. Without these patches no tests will
run as the platform won't match (aka "notapplicable").


I haven't done much testing as I'm on vacation until next week.


Also there are plenty of places that mention RHEL (grep says 155x "Red
Hat Enterprise Linux", 336x "RHEL"). e.g: "After upgrading to RHEL 7
....", "w3m not available in Red Hat Enterprise Linux 7", etc..
Should we replace all of them?


cheers,
manuel


-------------- next part --------------
A non-text attachment was scrubbed...
Name: openscap-centos-platform.patch
Type: text/x-diff
Size: 8212 bytes
Desc: not available
Url : http://lists.centos.org/pipermail/centos-devel/attachments/20140716/7dc114f3/attachment.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: preupgrade-assistant-centos-platform.patch
Type: text/x-diff
Size: 929 bytes
Desc: not available
Url : http://lists.centos.org/pipermail/centos-devel/attachments/20140716/7dc114f3/attachment-0001.bin

Search Discussions

  • Karanbir Singh at Jul 16, 2014 at 9:12 am

    On 07/16/2014 08:35 AM, Manuel Mausz wrote:
    Hi,

    attached are two patches to make the preupgrade assistant recognize
    centos and actually do something. Without these patches no tests will
    run as the platform won't match (aka "notapplicable").

    Thanks!

    Also there are plenty of places that mention RHEL (grep says 155x "Red
    Hat Enterprise Linux", 336x "RHEL"). e.g: "After upgrading to RHEL 7
    ....", "w3m not available in Red Hat Enterprise Linux 7", etc..
    Should we replace all of them?

    Thats a good question, the general rule of the thumb is, when in doubt :
    ask. Within that, how we typically decide on a branding change is :


    - Does it imply a RHEL way of doing something, then leave it in ( eg.
    the gcc -v says Red Hat, because well this is the Red Hat patched gcc )


    - Does it require cascading dependancies ( eg. he iscsi target name
    setup by default ), then look at scope and most likely leave it in.


    - Does it imply the platform being run on ? Change it


    - Can it be used by a third party to signigy that CentOS is identical to
    RHEL, then most likely change it


    - Is there a check for platform being RHEL ? then change it to match
    what one would expect in the same place on CentOS Linux.


    - Is this a user facing string that can be considered 'branding', then
    change it.


    Ofcourse, there are always exceptions but that is the basic stuff we
    consider since CentOS4 days :) Off the top of my head.


    So in your examples, I think we should consider changing most of those
    to point at and say CentOS.


    --
    Karanbir Singh
    +44-207-0999389 | http://www.karan.org/ | twitter.com/kbsingh
    GnuPG Key : http://www.karan.org/publickey.asc
  • Laurent Rineau at Jul 16, 2014 at 10:31 am

    Le Wednesday 16 July 2014 09:35:22 Manuel Mausz a ?crit :
    Hi,

    attached are two patches to make the preupgrade assistant recognize
    centos and actually do something. Without these patches no tests will
    run as the platform won't match (aka "notapplicable").

    Thanks for the patch. For testing, I patched the files directly in
    /usr/share/*/.


    Indeed, the preupg script does a different job now, and is a lot more useful!

    I haven't done much testing as I'm on vacation until next week.

    Also there are plenty of places that mention RHEL (grep says 155x "Red
    Hat Enterprise Linux", 336x "RHEL"). e.g: "After upgrading to RHEL 7
    ....", "w3m not available in Red Hat Enterprise Linux 7", etc..
    Should we replace all of them?

    Two things that must be patched, so that is can be fully usable:


      1/ It does not recognize CentOS as an authorized variant of RHEL. I quote
    from the results:
    ============
       Result for Red Hat Enterprise Linux Server variant


        Result: fail


        Rule ID: xccdf_preupg_rule_system_ServerOnly_server


        Time: 2014-07-16 12:01


        Upgrade is supported only to Red Hat Enterprise Linux Server variant.


         Remediation instructions


        Only upgrade of Red Hat Enterprise Linux Server variant is supported at the
    moment. Upgrade of Workstation, Client and Compute Node is not supported.




      extreme_risk [unknown]: This system is CentOS release 6.5 (Final)
      INPLACERISK: EXTREME: Only upgrade of Red Hat Enterprise Linux 6 Server is
    supported.
    ============


       2/ It complains about packages that are not signed by Redhat, and reports
    all packages singed by CentOS. I quote from the results:
    ============
       Result for Packages not signed by Red Hat


        Result: needs_action


        Rule ID: xccdf_preupg_rule_packages_NonRHSignedPkg_nonrhpkg


        Time: 2014-07-16 11:13


        Packages not signed by Red Hat will not be upgraded


         Remediation instructions


        Packages which are not signed with the official Red Hat keys will not be
    upgraded. These packages are typically provided by third parties or have been
    modified in some way. There is a high risk of
        incompatibility with these packages as they have not been verified by Red
    Hat. For upgrade assistance, contact the vendors of these packages.


        You can find a list of all unsigned packages including the vendor names in
    the kickstart/nonrhpkgs file.




      INPLACERISK: HIGH: We detected some non-RH signed packages, you can find the
    list in /root/preupgrade/./kickstart/nonrhpkgs. You need to handle them
    yourself!
    ============


    After that, the --force option of `redhat-upgrade-tool` is still needed.
    Without it, the tool says:
    ============
    setting up repos...
    preupgrade-assistant risk check found EXTREME risks for this upgrade.
    Run preupg --riskcheck --verbose to view these risks.
    Continuing with this upgrade is not recommended.
    zsh: exit 1 sudo redhat-upgrade-tool
    ============


    Now, I will go on with the `redhat-upgrade-tool` with --force, and report the
    results...
  • Manuel Mausz at Jul 19, 2014 at 6:04 am

    Quoting Laurent Rineau <laurent.rineau__fedora@normalesup.org>:


    Two things that must be patched, so that is can be fully usable:

    Attached is a patch which should fix both problems:
    * Disable the OS variants check as CentOS has none (afaik).
    * Replace the RH GPG Keys with the CentOS ones and rename the whole group


    I'm not really happy with my changes as right now I've to do the same
    modification twice. In the specific definition of the group as well as
    in the big composition file of all groups (all-xccd.xml).


    Using a tool from preupgrade-assistant (PA) I could generate the
    composition during build time which would reduce the changes by ~50%.
    However right now the required tool is not shipped with the RPM. So I
    could either add it to the sources of PA-contents or we create
    something like a PA-devel RPM which will be a build dependency for the
    PA-contents RPM.
    Thoughts?


    manuel


    -------------- next part --------------
    A non-text attachment was scrubbed...
    Name: 0001-disable-OS-variants-check-and-fix-signed-packages-ch.patch
    Type: text/x-diff
    Size: 17535 bytes
    Desc: not available
    Url : http://lists.centos.org/pipermail/centos-devel/attachments/20140719/97f21b36/attachment.bin
  • Manuel Mausz at Jul 23, 2014 at 1:20 pm
    Hi,


    attached are patches for preupgrade-assistant and
    preupgrade-assistant-content to better recognized CentOS and it's packages.


    With these patches applied preupgrade no longer recognize packages
    signed by CentOS as 3rd party. This also applies all files owned by the
    packages.


    Also the assessment is renamed from RHEL6_7 to CentOS6_7. So please run
    preupg with "-s CentOS6_7".


    The test results on my development machine now look fine. No more failed
    checks, false positives or negatives. So next thing I'll work on is the
    branding.


    cheers,
    manuel
    -------------- next part --------------
    A non-text attachment was scrubbed...
    Name: 0001-preupgrade-assistant.patch
    Type: text/x-diff
    Size: 8251 bytes
    Desc: not available
    Url : http://lists.centos.org/pipermail/centos-devel/attachments/20140723/cf3782d5/attachment.bin
    -------------- next part --------------
    A non-text attachment was scrubbed...
    Name: 0001-preupgrade-assistant-contents.patch
    Type: text/x-diff
    Size: 36325 bytes
    Desc: not available
    Url : http://lists.centos.org/pipermail/centos-devel/attachments/20140723/cf3782d5/attachment-0001.bin
  • Manuel Mausz at Jul 24, 2014 at 6:25 pm
    Hello,


    attached are the last pieces for getting the preupgrade assistant ready.


    As already outlined in one of my previous messages I now generate the
    big xml composition during build time. This greatly reduces the size of
    the needed rebranding patches, although it's still rather massive.


    I didn't rebrand links to the manual as it's not available right now.
    Same goes for links to the knowledgebase.


    As soon the packages has been rebuild by the CentOS guys please test the
    upgrade assistant. Just fire up the tool with preupg -s CentOS6_7 and
    look at the generated report. The assistant *won't modify any* of your
    files. Everything the assistant does is looking and analyzing your
    current system.
    The packages will be available at http://dev.centos.org/centos/6/upg/
    (wait for the preupgrade-assistant-contents-0.5.13-1.0.4 rpm)


    With these patches applied I consider the assistant to be complete. So
    please consider adding the package to the public repo. Or just sign it
    so the assistant won't detect itself as 3rd party :)


    manuel
    -------------- next part --------------
    A non-text attachment was scrubbed...
    Name: 0001-generate-xccdf.xml-file-during-build-process.patch
    Type: text/x-diff
    Size: 23228 bytes
    Desc: not available
    Url : http://lists.centos.org/pipermail/centos-devel/attachments/20140724/7dd43b69/attachment.bin
    -------------- next part --------------
    A non-text attachment was scrubbed...
    Name: 0002-add-missing-patch-to-the-centospkgs-patch.patch
    Type: text/x-diff
    Size: 2292 bytes
    Desc: not available
    Url : http://lists.centos.org/pipermail/centos-devel/attachments/20140724/7dd43b69/attachment-0001.bin
    -------------- next part --------------
    A non-text attachment was scrubbed...
    Name: 0003-disable-optional-RHEL-channels-check.patch
    Type: text/x-diff
    Size: 1828 bytes
    Desc: not available
    Url : http://lists.centos.org/pipermail/centos-devel/attachments/20140724/7dd43b69/attachment-0002.bin
    -------------- next part --------------
    A non-text attachment was scrubbed...
    Name: 0004-disable-RHN-classic-check.patch
    Type: text/x-diff
    Size: 1776 bytes
    Desc: not available
    Url : http://lists.centos.org/pipermail/centos-devel/attachments/20140724/7dd43b69/attachment-0003.bin
    -------------- next part --------------
    A non-text attachment was scrubbed...
    Name: 0005-add-CentOS-rebranding-patches-and-adapt-spec-to-the-.patch
    Type: text/x-diff
    Size: 190594 bytes
    Desc: not available
    Url : http://lists.centos.org/pipermail/centos-devel/attachments/20140724/7dd43b69/attachment-0004.bin
  • Manuel Mausz at Jul 24, 2014 at 6:34 pm

    On 07/24/2014 08:25 PM, Manuel Mausz wrote:
    attached are the last pieces for getting the preupgrade assistant ready.
    missed to cleanup an obsolete patch :)


    manuel
    -------------- next part --------------
    A non-text attachment was scrubbed...
    Name: 0006-remove-obsolete-centos-platform.patch.patch
    Type: text/x-diff
    Size: 1645 bytes
    Desc: not available
    Url : http://lists.centos.org/pipermail/centos-devel/attachments/20140724/95ecdbd6/attachment.bin
  • Johnny Hughes at Jul 16, 2014 at 12:57 pm

    On 07/16/2014 02:35 AM, Manuel Mausz wrote:
    Hi,

    attached are two patches to make the preupgrade assistant recognize
    centos and actually do something. Without these patches no tests will
    run as the platform won't match (aka "notapplicable").

    I haven't done much testing as I'm on vacation until next week.

    Also there are plenty of places that mention RHEL (grep says 155x "Red
    Hat Enterprise Linux", 336x "RHEL"). e.g: "After upgrading to RHEL 7
    ....", "w3m not available in Red Hat Enterprise Linux 7", etc..
    Should we replace all of them?

    Manual ... thanks very much, changes rolled in and packages with these
    patches are now posted here:


    http://dev.centos.org/centos/6/upg/


    Lets get some more testers and more patches.


    -------------- next part --------------
    A non-text attachment was scrubbed...
    Name: signature.asc
    Type: application/pgp-signature
    Size: 198 bytes
    Desc: OpenPGP digital signature
    Url : http://lists.centos.org/pipermail/centos-devel/attachments/20140716/3713c9b3/attachment.bin
  • Johnny Hughes at Jul 16, 2014 at 1:01 pm

    On 07/16/2014 07:57 AM, Johnny Hughes wrote:
    On 07/16/2014 02:35 AM, Manuel Mausz wrote:
    Hi,

    attached are two patches to make the preupgrade assistant recognize
    centos and actually do something. Without these patches no tests will
    run as the platform won't match (aka "notapplicable").

    I haven't done much testing as I'm on vacation until next week.

    Also there are plenty of places that mention RHEL (grep says 155x "Red
    Hat Enterprise Linux", 336x "RHEL"). e.g: "After upgrading to RHEL 7
    ....", "w3m not available in Red Hat Enterprise Linux 7", etc..
    Should we replace all of them?
    Manual ... thanks very much, changes rolled in and packages with these
    patches are now posted here:

    s/Manual/Manuel .. me and my typos :)


    <snip>


    -------------- next part --------------
    A non-text attachment was scrubbed...
    Name: signature.asc
    Type: application/pgp-signature
    Size: 198 bytes
    Desc: OpenPGP digital signature
    Url : http://lists.centos.org/pipermail/centos-devel/attachments/20140716/9ff59b49/attachment.bin

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupcentos-devel @
categoriescentos
postedJul 16, '14 at 7:35a
activeJul 24, '14 at 6:34p
posts9
users4
websitecentos.org
irc#centos

People

Translate

site design / logo © 2021 Grokbase