FAQ
[ https://issues.apache.org/cayenne/browse/CAY-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Razumovsky updated CAY-1104:
-----------------------------------

Attachment: fix-scenario1.txt

The first bug happens because-of map of attributes in DbEntity is not updated properly (i.e. map key is old, but attr itself has new name). This is easy to fix (I uploaded small patch which does manual update), but I still cannot figure out why it works in M4. The only way to update cache automatically seems to have DbEntity as registered DbAttributeListener. But noone adds it to ProjectController. So I'm a bit confused here.

Scenario 2 is about table behavior. Target field (or any other table editor information!) will not be saved if you lose table's focus when table is being edited. I.e. I assume the information gets lost when you press 'Done' while combo is edited and filled with new unsaved information. If you hit 'Enter' or move focus to other column, new info will be applied.
Similiar sutiation can happen e.g. when you switch to other entity in the tree while editing attribute's name. Other VERY irritating thing is that editor information is lost when you click at table's header.
We have two choices here:
#1. Workaround: stop and save table editing when hitting 'Done'
#2. stop and save table editing anytime focus is lost.

Personally I'd prefer #2 more but note that then the only way to cancel editing will be to hit 'Escape'
Modeler misses new renamed attributes, relationship mappings
------------------------------------------------------------

Key: CAY-1104
URL: https://issues.apache.org/cayenne/browse/CAY-1104
Project: Cayenne
Issue Type: Bug
Components: CayenneModeler GUI
Affects Versions: 3.0
Reporter: Andrus Adamchik
Assignee: Andrus Adamchik
Fix For: 3.0

Attachments: fix-scenario1.txt


Something else is badly broken on the trunk compared to M4.
Scenario 1:
1. Add a new DbAttribute to an existing DbEntity.
2. Rename it from default "untitledXXX" to something else.
3. Go the ObjEntity of this DbEntity and try to add a new ObjAttribute
At this point the list of DbAttributes still lists "untitledXXX" , not the new name of the new DbAttribute.
Scenario 2:
1. Add a new DbRelationship between 2 existing DbEntities
2. Open join mapping dialog and select source and target keys
3. Close join mapping dialog
4. Open it again
At this point join target is blank
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Andrus Adamchik at Sep 5, 2008 at 12:40 pm

    On Sep 5, 2008, at 12:38 PM, Andrey Razumovsky (JIRA) wrote:

    Scenario 2 is about table behavior. Target field (or any other table
    editor information!) will not be saved if you lose table's focus
    when table is being edited. I.e. I assume the information gets lost
    when you press 'Done' while combo is edited and filled with new
    unsaved information. If you hit 'Enter' or move focus to other
    column, new info will be applied.
    Similiar sutiation can happen e.g. when you switch to other entity
    in the tree while editing attribute's name. Other VERY irritating
    thing is that editor information is lost when you click at table's
    header.
    We have two choices here:
    #1. Workaround: stop and save table editing when hitting 'Done'
    #2. stop and save table editing anytime focus is lost.
    Hi Andrey,

    I think we had #2 behavior in M4. So was there a global change that
    affected all JComboBoxes?

    Andrus
  • Andrey Razumovsky at Sep 6, 2008 at 2:55 am
    Hi Andrus,

    I hadn't said that :-) It's not only about comboboxes, but about simple
    textfields too. I've just suggested way to fix that because I agree that
    this is an irritating UI problem

    2008/9/5, Andrus Adamchik <andrus@objectstyle.org>:

    On Sep 5, 2008, at 12:38 PM, Andrey Razumovsky (JIRA) wrote:

    Scenario 2 is about table behavior. Target field (or any other table editor
    information!) will not be saved if you lose table's focus when table is
    being edited. I.e. I assume the information gets lost when you press 'Done'
    while combo is edited and filled with new unsaved information. If you hit
    'Enter' or move focus to other column, new info will be applied.
    Similiar sutiation can happen e.g. when you switch to other entity in the
    tree while editing attribute's name. Other VERY irritating thing is that
    editor information is lost when you click at table's header.
    We have two choices here:
    #1. Workaround: stop and save table editing when hitting 'Done'
    #2. stop and save table editing anytime focus is lost.
    Hi Andrey,

    I think we had #2 behavior in M4. So was there a global change that
    affected all JComboBoxes?

    Andrus
  • Andrus Adamchik at Sep 6, 2008 at 2:15 pm

    On Sep 6, 2008, at 5:54 AM, Andrey Razumovsky wrote:

    I hadn't said that :-) It's not only about comboboxes, but about
    simple
    textfields too. I've just suggested way to fix that because I agree
    that
    this is an irritating UI problem

    Sorry, I what I was referring to is that comboboxes in M4 modeler
    behaved differently, so I was trying to figure out what has changed.
    And I did now - the comboboxes are editable in M5, so that's the
    reason for the different behavior (doh! that should've been obvious).
    #1. Workaround: stop and save table editing when hitting 'Done'
    #2. stop and save table editing anytime focus is lost.

    I think I am in favor of #2 fix. Maybe we can create a patch for that
    and try it out to see if it makes things more user friendly.

    Thanks,
    Andrus
  • Anonymous at Sep 7, 2008 at 6:08 pm
    [ https://issues.apache.org/cayenne/browse/CAY-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Andrey Razumovsky updated CAY-1104:
    -----------------------------------

    Attachment: fix-scenario2.txt

    Sure we can! I've analyzed the combobox behavior a bit more. Turns out default combo editors do stop editing when an item is selected. In autocompletion we cannot do that (selecting items is suggestion list would not work). So I added stopping editing at focus lost. This seems to fix your scenario. Still, situation with table headers I mentioned has not changed. It is a match against default java behavior and needs much more effort, this is probably a separate issue.
    Modeler misses new renamed attributes, relationship mappings
    ------------------------------------------------------------

    Key: CAY-1104
    URL: https://issues.apache.org/cayenne/browse/CAY-1104
    Project: Cayenne
    Issue Type: Bug
    Components: CayenneModeler GUI
    Affects Versions: 3.0
    Reporter: Andrus Adamchik
    Assignee: Andrus Adamchik
    Fix For: 3.0

    Attachments: fix-scenario1.txt, fix-scenario2.txt


    Something else is badly broken on the trunk compared to M4.
    Scenario 1:
    1. Add a new DbAttribute to an existing DbEntity.
    2. Rename it from default "untitledXXX" to something else.
    3. Go the ObjEntity of this DbEntity and try to add a new ObjAttribute
    At this point the list of DbAttributes still lists "untitledXXX" , not the new name of the new DbAttribute.
    Scenario 2:
    1. Add a new DbRelationship between 2 existing DbEntities
    2. Open join mapping dialog and select source and target keys
    3. Close join mapping dialog
    4. Open it again
    At this point join target is blank
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Anonymous at Sep 8, 2008 at 7:16 am
    [ https://issues.apache.org/cayenne/browse/CAY-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Andrus Adamchik closed CAY-1104.
    --------------------------------

    Resolution: Fixed
    Modeler misses new renamed attributes, relationship mappings
    ------------------------------------------------------------

    Key: CAY-1104
    URL: https://issues.apache.org/cayenne/browse/CAY-1104
    Project: Cayenne
    Issue Type: Bug
    Components: CayenneModeler GUI
    Affects Versions: 3.0
    Reporter: Andrus Adamchik
    Assignee: Andrus Adamchik
    Fix For: 3.0

    Attachments: fix-scenario1.txt, fix-scenario2.txt


    Something else is badly broken on the trunk compared to M4.
    Scenario 1:
    1. Add a new DbAttribute to an existing DbEntity.
    2. Rename it from default "untitledXXX" to something else.
    3. Go the ObjEntity of this DbEntity and try to add a new ObjAttribute
    At this point the list of DbAttributes still lists "untitledXXX" , not the new name of the new DbAttribute.
    Scenario 2:
    1. Add a new DbRelationship between 2 existing DbEntities
    2. Open join mapping dialog and select source and target keys
    3. Close join mapping dialog
    4. Open it again
    At this point join target is blank
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categoriescayenne
postedSep 5, '08 at 9:39a
activeSep 8, '08 at 7:16a
posts6
users3
websitecayenne.apache.org

People

Translate

site design / logo © 2022 Grokbase