[Cayenne-dev] [jira] Created: (CAY-1083) General Preferences Panel - items misaligned

[ https://issues.apache.org/cayenne/browse/CAY-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019#action_13019 ]

Kevin Menard commented on CAY-1083:
-----------------------------------

I'll look into the alignment issue.

As for the capitalization, there is an inconsistency. I advocate lower-casing the others. I think I left them upper-case because they were only 2 - 3 word labels, while my labels are much longer. I consulted the Gnome HIG [1] and they recommend using standard sentence capitalization in that case. According to the Java cross-platform HIG [2] and they recommend header capitalization, but all their examples are 1 - 2 word labels.

My personal feeling is that using header capitalization on a 5 word sentence is not the way to go. But, if it's what the Java HIG dictate, I'll concede.

[1] -- http://developer.gnome.org/projects/gup/hig/draft_hig_new/design-text-labels.html
[2] -- http://java.sun.com/products/jlf/ed2/book/HIG.Preface.html

[ https://issues.apache.org/cayenne/browse/CAY-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Menard closed CAY-1083.
-----------------------------

Resolution: Fixed

I've just made everything capital in the interest of closing this out.

[ https://issues.apache.org/cayenne/browse/CAY-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032#action_13032 ]

Andrus Adamchik commented on CAY-1083:
--------------------------------------

Thanks for the capitalization fix. I think alignment issue still exists though

[ https://issues.apache.org/cayenne/browse/CAY-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033#action_13033 ]

Kevin Menard commented on CAY-1083:
-----------------------------------

Hmm . . . I'm not seeing the alignment issue anymore. The problem was that the first column was set to right-align by default and those checkbox labels were varying length. I overrode both of them to left-align, which looked like it fixed things locally.

Can you attach another screenshot?

[ https://issues.apache.org/cayenne/browse/CAY-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034#action_13034 ]

Andrus Adamchik commented on CAY-1083:
--------------------------------------

Yeah, the checkboxes are aligned now. I was thinking that the content above (Preferences Save Interval and File encoding) should be aligned with checkboxes. Do you think this makes sense?

[ https://issues.apache.org/cayenne/browse/CAY-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035#action_13035 ]

Kevin Menard commented on CAY-1083:
-----------------------------------

It depends on what you value more: lined up fields or standard UI. As is, the Preferences Save Interval and File encoding fields are aligned, not their labels. The fields appear to the right of the labels. The checkboxes are rendered with the box appearing to the left of the label as is the Swing default. Lining everything up would require moving the checkbox to the right of the label. I'm not totally against that, but I think it would look a little odd.

I don't think things look terrible as they are now. I'm sure that as soon as another field is added, though, that this would need to be revisited. At that point, I think the solution would be clearer as well. It'd likely require a retooling of the form altogether, as I don't think centering everything is going to look that pretty with many fields.