Grokbase Groups Camel dev July 2008
FAQ
Add room support in consumer mode
---------------------------------

Key: CAMEL-757
URL: https://issues.apache.org/activemq/browse/CAMEL-757
Project: Apache Camel
Issue Type: Improvement
Components: camel-xmpp
Affects Versions: 1.4.0
Reporter: Vadim Chekan
Priority: Minor


Currently XmppEndpoint support room only for producer but not for consumer.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Claus Ibsen (JIRA) at Jul 29, 2008 at 5:44 pm
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44614#action_44614 ]

    Claus Ibsen commented on CAMEL-757:
    -----------------------------------

    Vadim I anticipate that you can create the consumer part as well and attach a patch? If so we can target this for Camel 1.5?
    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Priority: Minor

    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Claus Ibsen (JIRA) at Jul 29, 2008 at 5:48 pm
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Claus Ibsen updated CAMEL-757:
    ------------------------------

    Fix Version/s: 1.5.0
    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Priority: Minor
    Fix For: 1.5.0


    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Vadim Chekan (JIRA) at Jul 30, 2008 at 2:36 am
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44618#action_44618 ]

    Vadim Chekan commented on CAMEL-757:
    ------------------------------------

    Absolutely. I'm mostly done with the code and busy with QA and junit modifications. Likely I'll be done in 1-2 weeks so 1.5 is the target.
    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Priority: Minor
    Fix For: 1.5.0


    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Vadim Chekan (JIRA) at Jul 31, 2008 at 5:06 am
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Vadim Chekan updated CAMEL-757:
    -------------------------------

    Attachment: diff.txt

    Comments for the patch:

    Added support of MultiUserChat to XmppConsumer. I opted to add it into XmppConsumer instead of creating a separate XmppMultiUserchatConsumer because when I did it, it turned out to be two identical classes with slight differences.

    Bug fix.
    XmppConsumer listened to "raw" xmpp packages filtering and processing those of type "Message". Because of low-level nature of packages XmppConsumer failed to check either the type of message is "error" or "response" so unit test passed successfully because XmppComponent thought that message has been received when in fact echo with error message has been sent by server.
    I fixed it by removing listener to the raw xmpp connection packages and utilizing smack.Chat class which does all error detecting and other low level functions. It allowed to remove some extra code from XmppConsumer.processPacket too.

    XmppEndpoint
    As soon as nobody listens to the raw packages, no need to have PacketFilter property anymore.
    Added conference subdomain detection code (CAMEL-748 can be closed if patch is accepted)

    GroupChat Producer and Consumer: added attribute to suppress history messages to be sent upon room joining.

    Unit test:
    Had some problems with accounts kicking out each other when log in or join room. Solved by introducing 3 different resources/nicknames for a single account.
    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Priority: Minor
    Fix For: 1.5.0

    Attachments: diff.txt


    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Claus Ibsen (JIRA) at Jul 31, 2008 at 6:08 am
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44646#action_44646 ]

    Claus Ibsen commented on CAMEL-757:
    -----------------------------------

    Vadim

    You have this code. Could you explain with code comments why you are creating the private chat two times?

    privateChat = endpoint.getConnection().createChat(endpoint.getParticipant());
    + privateChat.addMessageListener(this);
    + privateChat = endpoint.getConnection().createChat(endpoint.getParticipant());

    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Priority: Minor
    Fix For: 1.5.0

    Attachments: diff.txt


    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Vadim Chekan (JIRA) at Jul 31, 2008 at 6:40 am
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Vadim Chekan updated CAMEL-757:
    -------------------------------

    Attachment: diff.txt

    /*
    * Because I'm a sleepy head :(
    */
    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Priority: Minor
    Fix For: 1.5.0

    Attachments: diff.txt


    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Vadim Chekan (JIRA) at Jul 31, 2008 at 6:40 am
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Vadim Chekan updated CAMEL-757:
    -------------------------------

    Attachment: (was: diff.txt)
    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Priority: Minor
    Fix For: 1.5.0

    Attachments: diff.txt


    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Vadim Chekan (JIRA) at Jul 31, 2008 at 6:44 am
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44648#action_44648 ]

    Vadim Chekan commented on CAMEL-757:
    ------------------------------------

    Replaced the attach.
    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Priority: Minor
    Fix For: 1.5.0

    Attachments: diff.txt


    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Vadim Chekan (JIRA) at Jul 31, 2008 at 6:58 am
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Vadim Chekan updated CAMEL-757:
    -------------------------------

    Attachment: (was: diff.txt)
    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Priority: Minor
    Fix For: 1.5.0

    Attachments: diff.txt


    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Vadim Chekan (JIRA) at Jul 31, 2008 at 6:58 am
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Vadim Chekan updated CAMEL-757:
    -------------------------------

    Attachment: diff.txt

    Another attempt to attach file.
    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Priority: Minor
    Fix For: 1.5.0

    Attachments: diff.txt


    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Claus Ibsen (JIRA) at Jul 31, 2008 at 7:42 am
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44650#action_44650 ]

    Claus Ibsen commented on CAMEL-757:
    -----------------------------------

    Vadim, nice patch. I have a few comments:

    - Would be nice with INFO logging in doStart() about connecting to ... so end-users can see what room / chat server / whatever is connected to (there is an if .. else in the start code)
    - You can fix the TODO about the swallowing exceptions by wrapping in a CamelRuntimeExchangeException or what is is called - see mail on dev forum

    And then is there any new stuff that needs to be updated in the wiki as well?
    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Priority: Minor
    Fix For: 1.5.0

    Attachments: diff.txt


    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Vadim Chekan (JIRA) at Aug 1, 2008 at 2:29 am
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Vadim Chekan updated CAMEL-757:
    -------------------------------

    Attachment: (was: diff.txt)
    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Priority: Minor
    Fix For: 1.5.0


    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Vadim Chekan (JIRA) at Aug 1, 2008 at 2:35 am
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Vadim Chekan updated CAMEL-757:
    -------------------------------

    Attachment: patch.txt

    Claus, thanks for your review and guidance.
    Attached new diff.

    Added logging in doStart()
    I do understand the issue with exceptions now. processPacket() which sends a message is invoked asynchronously from smack library. And it is defined as not throwing any exceptions because there is nobody up in the stack to handle it.
    It is tempting to add exception handling to camel process() call but it would be a bad idea. Sometimes endpoint needs information about success/failure for example jdbc endpoint would rollback transaction if message have not been sent.
    So I left try/catch but I replaced e.printStackTrace with LOG.error.
    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Priority: Minor
    Fix For: 1.5.0

    Attachments: patch.txt


    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Vadim Chekan (JIRA) at Aug 1, 2008 at 2:37 am
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44665#action_44665 ]

    Vadim Chekan commented on CAMEL-757:
    ------------------------------------

    Oh, and I'll take care about wiki update.
    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Priority: Minor
    Fix For: 1.5.0

    Attachments: patch.txt


    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Claus Ibsen (JIRA) at Aug 1, 2008 at 5:47 am
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44668#action_44668 ]

    Claus Ibsen commented on CAMEL-757:
    -----------------------------------

    Vadim. A good idea of patches is to name the files differenty, so for instance with the bug id number. You have attached a *patch.txt* that is a very small patch and not like the other one.

    Could you check it out and attach the correct path ;)
    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Priority: Minor
    Fix For: 1.5.0

    Attachments: patch.txt


    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Vadim Chekan (JIRA) at Aug 2, 2008 at 7:57 pm
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Vadim Chekan updated CAMEL-757:
    -------------------------------

    Attachment: diff-757.txt

    Ok, another attempt to attach the correct file :)
    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Priority: Minor
    Fix For: 1.5.0

    Attachments: diff-757.txt


    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Vadim Chekan (JIRA) at Aug 2, 2008 at 7:57 pm
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Vadim Chekan updated CAMEL-757:
    -------------------------------

    Attachment: (was: patch.txt)
    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Priority: Minor
    Fix For: 1.5.0

    Attachments: diff-757.txt


    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Claus Ibsen (JIRA) at Aug 4, 2008 at 6:00 pm
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Claus Ibsen reassigned CAMEL-757:
    ---------------------------------

    Assignee: Claus Ibsen
    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Assignee: Claus Ibsen
    Priority: Minor
    Fix For: 1.5.0

    Attachments: diff-757.txt


    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Claus Ibsen (JIRA) at Aug 4, 2008 at 7:08 pm
    [ https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Claus Ibsen resolved CAMEL-757.
    -------------------------------

    Resolution: Fixed

    Applied patch with thanks to Vadim. Thanks again for all the hard work on the XMPP stuff.
    Add room support in consumer mode
    ---------------------------------

    Key: CAMEL-757
    URL: https://issues.apache.org/activemq/browse/CAMEL-757
    Project: Apache Camel
    Issue Type: Improvement
    Components: camel-xmpp
    Affects Versions: 1.4.0
    Reporter: Vadim Chekan
    Assignee: Claus Ibsen
    Priority: Minor
    Fix For: 1.5.0

    Attachments: diff-757.txt


    Currently XmppEndpoint support room only for producer but not for consumer.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categoriescamel
postedJul 25, '08 at 7:01a
activeAug 4, '08 at 7:08p
posts20
users1
websitecamel.apache.org

1 user in discussion

Claus Ibsen (JIRA): 20 posts

People

Translate

site design / logo © 2022 Grokbase