[ http://issues.apache.org/jira/browse/VELTOOLS-69?page=comments#action_12450152 ]

Claude Brisson commented on VELTOOLS-69:

But isn't the conversion of native datatypes a task dedicated to velocity itself, at the time the reference is used in a comparison or as an argument? It seems to me that the need for $query.foo.int/number/boolean/double... becomes quite marginal with conversions built in velocity 1.5, and that in those rare cases where you absolutely need an exact type you can call $query.getInt("foo").

As for the case of a period inside the key, IMHO it shoud go into the core. There are numerous other cases where it could be useful.

ValueParserSub generic getter never worked

URL: http://issues.apache.org/jira/browse/VELTOOLS-69
Project: VelocityTools
Issue Type: Bug
Components: VelocityView
Affects Versions: 1.3
Reporter: Claude Brisson
Attachments: valueparser.patch

(I attach this issue to the VelocityView component but we may need a Generic component in Jira)
When $query is the ValueParser object for the query string http://...?foo=5,
then $query.foo.int is an invalid reference.
Why? Because there is a collision of variable names in ValueParserSub.get(Object key).
I profit of this opportunity to state that I really don't like the ValueParserSub class, because it breaks the "#if($query.foo)" syntax. Hence, it is not backward compatible. Or at least, it could return null for an unexistant key.
Is it really usefull to keep it now that Velocity handles conversions much better? Since obviously nobody used the $query.foo.int feature, it is still time to remove it... Also, since the need to convert between types can emerge elsewhere, it would be much cleaner to have a standalone converter object. Yes, we loose the syntax $query.foo.int, but is it that nice a syntax?
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org

Search Discussions

Discussion Posts


Follow ups

Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 4 of 14 | next ›
Discussion Overview
groupdev @
postedNov 15, '06 at 11:35a
activeNov 6, '07 at 1:27p

2 users in discussion

Nathan Bubna (JIRA): 11 posts Anonymous: 3 posts



site design / logo © 2021 Grokbase