On 2013-07-07 11:11:49 -0400, Tom Lane wrote:
Fabien COELHO <coelho@cri.ensmp.fr> writes:
Generally, I think that the tests which return a syntax error are of
limited value and should probably be dropped.
I think that it is not that simple: it is a good value to check that the
syntax error message conveys a useful information for the user, and that
changes to the parser rules do not alter good quality error messages.
It's good to check those things when a feature is implemented. However,
once it's done, the odds of the bison parser breaking are very low.
Thus, the benefit of testing that over again thousands of times a day
is pretty tiny.
There has been quite some talk about simplifying the grammar/scanner
though, if somebody starts to work on that *good* tests on syntax errors
might actually be rather worthwhile. Imo there's the danger of reducing
the specifity of error messages when doing so.
Granted, that probably mostly holds true for things actually dealing
with expressions...


Andres Freund

  Andres Freund http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services

Search Discussions

Discussion Posts


Follow ups

Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 8 of 13 | next ›
Discussion Overview
grouppgsql-hackers @
postedMar 19, '13 at 10:11p
activeJul 15, '13 at 4:34p



site design / logo © 2021 Grokbase