[PostgreSQL-Hackers] elog during holding a spinlock is safe?

[PostgreSQL-Hackers] elog during holding a spinlock is safe?

	Tom Lane
	Sep 15, 2010 at 2:47 am

Fujii Masao writes:
In HEAD, OwnLatch can elog during holding the spinlock WalSnd->mutex.
This seems to be unsafe

Even if it were safe, holding a spinlock through non-straight-line code
is a complete violation of the spinlock coding rules re the length of
time you're supposed to hold the lock. Heikki?

regards, tom lane

Search Discussions

Discussion Posts

Fujii Masao: Hi, In HEAD, OwnLatch can elog during holding the spinlock WalSnd->mutex. This seems to be unsafe because that elog would cause the walsender to exit without releasing the spinlock. Because of the spinlock being held, subsequent walsender would get stuck. I wonder if OwnLatch really needs to be protected by the spinlock. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center

Follow ups

Heikki Linnakangas: Yep, that's an oversight. I'll move the OwnLatch call after the spinlock is released. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com

Related Discussions

Discussion Navigation

view	thread \| post
posts	‹ prev \| 2 of 3 \| next ›

Discussion Overview

group	pgsql-hackers @
categories	postgresql
posted	Sep 15, '10 at 2:27a
active	Sep 15, '10 at 6:52a
posts	3
users	3
website	postgresql.org...
irc	#postgresql

font	variable	Hotkey: f
user style	avatars	Hotkey: a

[PostgreSQL-Hackers] elog during holding a spinlock is safe?

Search Discussions

Discussion Posts

Related Discussions

3 users in discussion