Grokbase Groups Pig dev March 2013
FAQ
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10035/#review18127
-----------------------------------------------------------



http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/PColFilterExtractor.java
<https://reviews.apache.org/r/10035/#comment38252>

remove dead code?



http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/PColFilterExtractor.java
<https://reviews.apache.org/r/10035/#comment38255>

(A and B) or (C and D)

is impossible if (A or C) is false. We can push this up, while retaining the original filter to apply the original filter.



http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/PColFilterExtractor.java
<https://reviews.apache.org/r/10035/#comment38253>

looks like tabulation is off?



http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/PColFilterExtractor.java
<https://reviews.apache.org/r/10035/#comment38254>

please fix whitespace



http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestPartitionFilterPushDown.java
<https://reviews.apache.org/r/10035/#comment38256>

is this new code or is this RB being funny?

either way, dead code can be deleted; this is preferable to commenting it out.


- Dmitriy Ryaboy

On March 20, 2013, 12:16 a.m., Rohini Palaniswamy wrote:

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10035/
-----------------------------------------------------------

(Updated March 20, 2013, 12:16 a.m.)


Review request for pig.


Description
-------

1) Fixed cases where partition pushdown was not happening for AND and OR construct
2) Commented out the negative test cases as they were actually not asserting anything.


This addresses bug PIG-3173.
https://issues.apache.org/jira/browse/PIG-3173


Diffs
-----

http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/PColFilterExtractor.java 1458047
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestPartitionFilterPushDown.java 1458047

Diff: https://reviews.apache.org/r/10035/diff/


Testing
-------

Unit tests added and tested few cases manually with hcat.


Thanks,

Rohini Palaniswamy

Search Discussions

Discussion Posts

Previous

Follow ups

Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 2 of 6 | next ›
Discussion Overview
groupdev @
categoriespig, hadoop
postedMar 20, '13 at 12:16a
activeApr 29, '13 at 8:51p
posts6
users3
websitepig.apache.org

People

Translate

site design / logo © 2021 Grokbase