[PHP-INTERNALS] Bug in zend_hash_init()

	Antony Dovgal
	Apr 28, 2011 at 11:50 am

On 04/28/2011 02:53 PM, Anton Dobkin wrote:
// No checking on return value?

Yes, it doesn't check for NULL.
See ecalloc() sources in Zend/zend_alloc.c around line 2434 to see why.

--
Wbr,
Antony Dovgal
---
http://pinba.org - realtime statistics for PHP

Search Discussions

Anton Dobkin: Hi, In function zend_hash_init() when allocate no persistent memory (if flag persistent is 0) for arBuckets element of struct HashTable and virtual memory is over, the function always returns SUCCESS Code: if (persistent) { tmp = (Bucket **) calloc(ht->nTableSize, sizeof(Bucket *)); if (!tmp) { return FAILURE; } ht->arBuckets = tmp; } else { // No checking on return value? tmp = (Bucket **) ecalloc_rel(ht->nTableSize, sizeof(Bucket *)); if (tmp) { ht->arBuckets = tmp; } }

Discussion Navigation

view	thread \| post
posts	‹ prev \| 2 of 2 \| next ›

Discussion Overview

font	variable	Hotkey: f
user style	avatars	Hotkey: a