Grokbase Groups PHP php-cvs May 2016
FAQ
Commit: c3495d5dc0569b5b024be1e50f357b1b97c76d12
Author: Xinchen Hui <laruence@gmail.com> Sat, 28 May 2016 15:15:53 +0800
Parents: 4935c032762c376c19308b7cdf1b77780f1b073a
Branches: master

Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=c3495d5dc0569b5b024be1e50f357b1b97c76d12

Log:
This is not a problem here

if only for PHI placement, we may get rid of this `use` here.
But as the comment said, it is useful if we are going to do code generation

Changed paths:
   M ext/opcache/Optimizer/zend_dfg.c


Diff:
diff --git a/ext/opcache/Optimizer/zend_dfg.c b/ext/opcache/Optimizer/zend_dfg.c
index abc9b3a..d5be92d 100644
--- a/ext/opcache/Optimizer/zend_dfg.c
+++ b/ext/opcache/Optimizer/zend_dfg.c
@@ -124,7 +124,8 @@ int zend_build_dfg(const zend_op_array *op_array, const zend_cfg *cfg, zend_dfg
       case ZEND_FETCH_OBJ_UNSET:
       case ZEND_VERIFY_RETURN_TYPE:
  op1_def:
- // FIXME: include into "use" too ...?
+ /* `def` always come along with dtor or separation,
+ * thus the origin var info might be also `use`d in the feature(CG) */
        DFG_SET(use, set_size, j, var_num);
        DFG_SET(def, set_size, j, var_num);
        break;

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
posts ‹ prev | 1 of 1 | next ›
Discussion Overview
groupphp-cvs @
categoriesphp
postedMay 28, '16 at 7:17a
activeMay 28, '16 at 7:17a
posts1
users1
websitephp.net

1 user in discussion

Xinchen Hui: 1 post

People

Translate

site design / logo © 2019 Grokbase