Edit report at http://pear.php.net/bugs/bug.php?id=18283&edit=1
ID: 18283
Updated by: gsherwood@squiz.net
Reported By: dave at recurser dot com
Summary: Squiz doesn't handle 'final' keyword before function
comments
-Status: Open
+Status: Duplicate
Type: Feature/Change Request
Package: PHP_CodeSniffer
Operating System: ubuntu
Package Version: 1.3.0RC2
PHP Version: 5.3.1
-Assigned To:
+Assigned To: squiz
Roadmap Versions:
New Comment:
-Status: Open
+Status: Duplicate
-Assigned To:
+Assigned To: squiz
Duplicate report for bug #18282
Previous Comments:
------------------------------------------------------------------------
[2011-02-17 14:23:51] recurser
Description:
------------
Squiz spits out a bunch of complaints if functions are defined
using the 'final' keyword.
Need to add _T_FINAL_ to the _$ignore_ list in the _process()_
functions :
Standards/Squiz/Sniffs/Commenting/BlockCommentSniff.php
74d73
< T_FINAL,
Standards/Squiz/Sniffs/Commenting/InlineCommentSniff.php
85d84
< T_FINAL,
Expected result:
----------------
No errors.
Actual result:
--------------
43:5 Inline doc block comments are not allowed; use "/*
Comment */" or "// Comment" instead
Squiz.Commenting.InlineComment.DocBlock
44:1 First line of comment not aligned correctly; expected 8
spaces but found 5
Squiz.Commenting.BlockComment.FirstLineIndent
44:1 Block comments must start with a capital letter
Squiz.Commenting.BlockComment.NoCaptial
45:1 Comment line indented incorrectly; expected at least 8
spaces but found 5
Squiz.Commenting.BlockComment.LineIndent
46:1 Comment line indented incorrectly; expected at least 8
spaces but found 5
Squiz.Commenting.BlockComment.LineIndent
47:1 Last line of comment aligned incorrectly; expected 4
spaces but found 5
Squiz.Commenting.BlockComment.LastLineIndent
47:1 Empty line required after block comment
Squiz.Commenting.BlockComment.NoEmptyLineAf
------------------------------------------------------------------------
